463786 - selecting folder gives eternal spinning pointer if delete button not on toolbar

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Tuukka Tolvanen (sp3000)]

thunderbird trunk 2008-11-08-10Z

steps:
 A1. customize toolbar, add delete button if not present, restart
 A2. click on folder with unread -> no persistent spinner pointer
 A3. press N -> an unread message is selected

 B1. customize toolbar, remove delete button, restart
 B2. click on folder with unread -> persistent spinner pointer
 B3. press N -> ...uh, I could have sworn this didn't work last time

Anyhow, I do get that persistent waiting pointer when  folder is selected, if I have no delete button on the toolbar. No errors on console besides a "Duplicate resource declaration for 'gloda'" and "Timed textboxes are deprecated".

Also, some actions (like selecting Trash for the first time? these pop up slightly randomly while going through and deleting messages) give this error:

Error: deleteButton is null
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 1885

Comment 1

[Tuukka Tolvanen (sp3000)]

regressed at http://hg.mozilla.org/comm-central/rev/da8475453ed5 bug 440616 for both the persistently spinning pointer and the error on selecting trash (although the latter is not entirely reliable)

Comment 2

[Joey Minta]

Attachment: potential patch

I forgot about the potential for people to remove this button. This will at least fix the errors.

Comment 3

[Tuukka Tolvanen (sp3000)]

that seems to fix both issues.

Comment 4

[David :Bienvenu]

r=me, if Phil doesn't get to this soon and you want to check in the fix.

Comment 5

[Joey Minta]

Pushed as rev e7a3766328c9.

Comment 6

[Joey Minta]

Attachment: mozmill test

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 348310 [details] [diff] [review]
mozmill test

>diff -r c1b539eb4588 mail/base/test/test_bug463786.js

Please locate in mail/tests/mozmill

>+var  MC = new controller.MozMillController(mainWindow);

nit: only one space between var and MC.

>+  let button = MC.window.document.getElementById("button-delete");
>+  let parent = button.parentNode;
>+  // remember where it is so we can put things back
>+  var index = -1;
>+  for (let i = 0; i < parent.childNodes.length; i++) {
>+    if (parent.childNodes[i] == button) {
>+      index = i;
>+      break;
>+    }
>+  }
>+  parent.removeChild(button);

This sequence doesn't work as you expect - the tests still passes if I back out the patch that fixed it.

>\ No newline at end of file

Please fix.