463810 - Add ellipsis to "Clear Recent History" button in about:privatebrowsing

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[u60234]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081108 Minefield/3.1b2pre

Shouldn't there be an ellipsis in the "Clear Recent History" button label in about:privatebrowsing? No history is cleared without further input from the user, and the Tools -> Clear Recent History… menuitem that opens the same window has an ellipsis.

Steps to reproduce:
1. Enter Private Browsing mode via Tools -> Private Browsing
2. Fear immediate loss of your history if you touch the "Clear Recent History" button.

Comment 1

[(no longer active)]

CCing faaborg for input.  Alex, do we want an ellipsis for the "Start Private Browsing" button in bug 463400 as well?

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

>Shouldn't there be an ellipsis in the "Clear Recent History" button label in
>about:privatebrowsing?

Yep, I messed that up in the mockup, sorry about that.

>Alex, do we want an ellipsis for the "Start Private
>Browsing" button in bug 463400 as well?

The menu command doesn't have it.  In this case if the user has checked the prompt not to appear, the action will be immediate.  In general the ellipses implies more input will be required, so I would say probably no.  For instance, File > Exit doesn't have an ellipsis even though it produces a dialog box asking if you want to save your session.

Comment 3

[(no longer active)]

Attachment: Patch (v1)

Comment 4

[(no longer active)]

Comment on attachment 347636 [details] [diff] [review]
Patch (v1)

No risk, nice to take for beta 2.

Comment 5

[(no longer active)]

Attachment: UTF-8 patch, fwiw

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 347638 [details] [diff] [review]
UTF-8 patch, fwiw

r+ but a- as this is latel10n we can't take it for b2

Comment 7

[Vlado Valastiak [:wladow]]

If you want all 60 locales to catch this, you need to change entity's name.

Comment 8

[(no longer active)]

Attachment: For checkin

(In reply to comment #7)
> If you want all 60 locales to catch this, you need to change entity's name.

Done.

Comment 9

[(no longer active)]

Attachment: For checkin

The previous patch was missing the changes to aboutPrivateBrowsing.xhtml...

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348088 [details] [diff] [review]
For checkin

a191=beltzner

Comment 11

[(no longer active)]

Attachment: mq patch for check-in

Comment 12

[Shawn Wilsher :sdwilsh]

Please make sure you qrefresh with -U in the future.  I almost pushed this as me because there was no username stored in the patchfile.

http://hg.mozilla.org/mozilla-central/rev/9bf88e2ecc45

Comment 13

[(no longer active)]

(In reply to comment #12)
> Please make sure you qrefresh with -U in the future.  I almost pushed this as
> me because there was no username stored in the patchfile.

Sorry for the inconvenience.  Didn't know this.  I noted this in the MeteredCheckins page.

Comment 14

[Marcia Knous [:marcia]]

Looks good using ozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20081216 Shiretoko/3.1b3pre. Will verify on Mac and Linux next.

Comment 15

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.

Comment 16

[Marcia Knous [:marcia]]

Verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081222 Shiretoko/3.1b3pre as well as on Intel Tiger Mac.

Also looks fine on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20081222 Minefield/3.2a1pre

Comment 17

[:Gavin Sharp [email: [e-mail]]]

This landed pre-branching, so fixed1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9bf88e2ecc45
(was showing up in my queries of late-l10n bugs needing checkin)

Comment 18

[Aakash Desai [:aakashd]]

verified FIXED on Shiretoko: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b5pre) Gecko/20090513 Shiretoko/3.5b5pre ID:20090513030639