463813 - Join Channel dialog includes private channel marker and it breaks sorting

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[James Ross]

When you do /LIST on a server with at least one private channel, you get a channel entry with a name of "*" (and no user count or topic) to show that there are >0 private channels.

The Join Channel dialog dislikes this entry, showing users and topic as undefined and the sorting refuses to sort that entry (meaning the channels returned before and after get sorted as two distinct groups).

I propose we make the dialog disregard the "*"-named entry upon reading it.

Comment 1

[:Gijs (he/him)]

Sounds good! :-)

Comment 2

[James Ross]

There seems to be some unknown server behaviour involved here, as I just got moznet and the other network I use (which is where the problem originally occured) to show the * channel entry with a user count. It might be that it shows that if there's only 1 private channel, and omits it when there's >1.

Either way, I don't think we should bother including the * entry, as you can't join it in any case.

Comment 3

[James Ross]

Attachment: Exclude "*" channel entries from list

Comment 4

[:Gijs (he/him)]

Comment on attachment 415644 [details] [diff] [review]
Exclude "*" channel entries from list

Excellent, r=me.

Comment 5

[James Ross]

Pushed --> FIXED.