bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

gloda indexing logic failing to persist 'ghost' messages, breaking conversation logic badly

RESOLVED FIXED in Thunderbird 3.0b1

Status

MailNews Core
Backend
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: asuth, Assigned: asuth)

Tracking

Trunk
Thunderbird 3.0b1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 347108 [details] [diff] [review]
v1 persist ghost messages, trigger reindexing

The pre-landing gloda refactoring changed the semantics of GlodaDatastore::createMessage to not perform the insert, requiring a call to insertMessage to actually persist things.  This broke the hardy conversation logic.

The revitalized unit tests picked this up.  (I will post that patch next.)

This bug probably explains any conversation invariant problems.

Unfortunately, I am compelled to bump the db schema to compel a complete re-indexing.  Broken conversation logic is no conversation logic, and I want to be sure any new conversation invariant errors are legitimate and not the result of a non-reindexed database.
Attachment #347108 - Flags: review?(dmose)

Updated

10 years ago
Attachment #347108 - Flags: review?(dmose) → review+
Pushed: http://hg.mozilla.org/comm-central/rev/6c196c8e3c19
Assignee: nobody → bugmail
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in before you can comment on or make changes to this bug.