463974 - Omnibus ad-blocking bug for November/December 2008

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Over the river and through the woods, to ad-blocking's house we go…

Comment 1

[Chris Lawson (gone)]

Our ad-blocking is catching the weekly circular on meijer.com:

http://www.meijer.com/custserv/show_ad.cmd?cmpid=HeaderADAWAds

which, for me, leads to

http://www2.meijer.com/ads/default.aspx?sid=119

It might be worth whitelisting the entire meijer.com domain, since they're not likely to be a third-party ad host.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'd like to mark comment 1 a duplicate of bug 360402, but unfortunately Bugzilla is missing that feature ;)  I stand behind smfr's and my comments there.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On Earthlink webmail, there are ads with iframe nested within iframe nested within iframe; for whatever reason, we aren't blocking the iframes from ad.doubleclick.net and ad.yieldmanager.com (despite the rules against them), but that pointed out we also aren't blocking images from advertising.com.

img[src*=".advertising.com"]

Comment 4

[Chris Lawson (gone)]

There's an ad at the bottom of the page here:

http://www.wnep.com/Global/story.asp?S=9421229&nav=menu158_1

that's coming from this code:

<DIV ID="wrapper_wnsz_52" NAME="wrapper_wnsz_52">
<div style="text-align:center;"><img src="http://wnep.images.worldnow.com/images/static/gfx/adtext_horiz.gif"></div>
<div style="padding-bottom:14px;text-align:center;"><IFRAME id='wnsz_52' name='wnsz_52' WIDTH='300' HEIGHT='250' ALLOWTRANSPARENCY='true' STYLE='VISIBILITY: hidden; margin-top: 0px' FRAMEBORDER='0' BORDER='1' MARGINWIDTH='0' MARGINHEIGHT='0' SCROLLING='no'><SCRIPT LANGUAGE='JavaScript1.1'>if (document.layers) {document.write('<SCR' + 'IPT language=JavaScript1.1 SRC=/Global/ad.asp?type=single&cls1=News&src1=nat&spct1=50&sz1=wnsz_52&callType=script />'); document.close();}</SCRIPT></IFRAME><SCRIPT LANGUAGE="JavaScript1.1">coreAdsCreate('wnsz_52', 'nat', '50', 'wnsz_52', 'News');</SCRIPT></div>
</DIV>

I still haven't quite figured out what the source of that ad actually *is*; MODI doesn't want to tell me anything about the Flash itself because it's wrapped in a div and an iframe that are both page-local. Strangely, it doesn't show up in Safari at all, though I've got no ad-blocking other than Privoxy enabled in Safari (and it's also enabled for Camino).

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FWIW, that's blocked for me on a fresh profile (a Flash ad coming from http://speed.pointroll.com/PointRoll/Media/Banner s/LMDA(LincolnMercuryDealersAssociation)/630574/f _linc_natl_300x250_Bnr_112408_r01.swf)

Comment 6

[Chris Lawson (gone)]

There's a Flash ad on FlightAware.com just below the data block:

http://flightaware.com/live/flight/SWA8502 (for example; it's part of a rotating script so it might not show on every load)

<td style="border: solid 5px #ED8000;" colspan="2" class="midAd"><iframe src='http://lettuce.flightaware.com/delivery/afr.php?zoneid=41' framespacing='0' frameborder='no' scrolling='no' width='728' height='90'></iframe></td>

Worth blocking "midAd" ? Seems unlikely to generate false-positives, at least.

Comment 7

[Chris Lawson (gone)]

Ads all over the place on

http://greenevillesun.com/story/299828

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://macupdate.com/info.php/id/7548/camino

td[id="ad_gutter"]

Comment 9

[philippe (part-time)]

http://news.yahoo.com/ is missing part of the header (containing logo, searchbox, and the login nav bar)
The whole block is contained within
<div class="mod ad mod-first ad_header">
blocked by
div[class~="ad"]

Comment 10

[philippe (part-time)]

Before I forget:
On yahoo.co.jp, flash and img ads coming from ah.yimg.jp/bdv
we already deal with ai.yimg.jp
(We're testing this one since yesterday, so far no side issues on yahoo japan (news., weather.,...)

On the yahoo.co.jp frontpage, those ads are contained within div id="ADframe0.04062647186366464....", with width and height set - leaves a big gap...

div[id^="ADframe"] sends that one where the ads go resting.

Comment 11

[philippe (part-time)]

On articles linked from elpais.com/global, randomly swf ads
src contains: l3static.weborama.fr/adperf and ads.prisa.com

(we already have:
embed[type="application/x-shockwave-flash"][src*="cstatic.weborama.fr/weborama/adperf/"],)

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www.nytimes.com/

div[class="singleAd"]

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: block more ads

This covers everything here, with the exception of comment 1 (see comment 2), comment 4 (see comment 5, but there's also no reasonable way to block that <div> alone), and gets most, but not all, of the ads from comment 7.

I also moved the yahoo.jp img rules to sit next to the yahoo.com img rules, just as they are in the embed section.

Comment 14

[Stuart Morgan]

Comment on attachment 355253 [details] [diff] [review]
block more ads

Ads are delicious delicacies!
sr=smorgan

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.  This should certainly have enough baking by the time we get to spin 1.6.7....

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the 18branch in advance of 1.6.7.