Closed Bug 464000 Opened 16 years ago Closed 16 years ago

Testing output is not logged correctly.

Categories

(NSS :: Test, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
3.12.2

People

(Reporter: slavomir.katuscak+mozilla, Assigned: slavomir.katuscak+mozilla)

Details

Attachments

(1 file)

Normally all.sh print output of tests to its standard output and also to output.log file (using tee -a command). 

In libpkix.sh there are used some strange construction with another logfile libpkix log, and operations directly with output.log, which causes that last line of output.log is 'TIMESTAMP libpkix BEGIN: Fri Nov  7 04:17:29 PST 2008' and the rest is not there.

In testing script there should NOT be any operations using this output.log directly ($LOGFILE). Everything sent to stdout is also logged to output.log, if there is anything that should not be logged there, it should not go to stdout (can be redirected to another logfile).
Attached patch Patch.Splinter Review
Alexei, please review this patch ASAP, because it causes that nightly testing logs are incomplete (Tinderbox logs are OK). I removed all parts of code related to libpkix.log. If there are data that should not be logged to output.log, please create some new way how to use separate logfile (without touching $LOGFILE).
Assignee: nobody → slavomir.katuscak
Attachment #347265 - Flags: review?(alexei.volkov.bugs)
Btw, we are not running any tests from libpkix.sh now (because of bug 426510), so it should be only begin message and end message.
Attachment #347265 - Flags: review?(alexei.volkov.bugs) → review+
Checking in libpkix.sh;
/cvsroot/mozilla/security/nss/tests/libpkix/libpkix.sh,v  <--  libpkix.sh
new revision: 1.8; previous revision: 1.7
done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: