If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Testing output is not logged correctly.

RESOLVED FIXED in 3.12.2

Status

NSS
Test
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Slavomir Katuscak, Assigned: Slavomir Katuscak)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Normally all.sh print output of tests to its standard output and also to output.log file (using tee -a command). 

In libpkix.sh there are used some strange construction with another logfile libpkix log, and operations directly with output.log, which causes that last line of output.log is 'TIMESTAMP libpkix BEGIN: Fri Nov  7 04:17:29 PST 2008' and the rest is not there.

In testing script there should NOT be any operations using this output.log directly ($LOGFILE). Everything sent to stdout is also logged to output.log, if there is anything that should not be logged there, it should not go to stdout (can be redirected to another logfile).
(Assignee)

Comment 1

9 years ago
Created attachment 347265 [details] [diff] [review]
Patch.

Alexei, please review this patch ASAP, because it causes that nightly testing logs are incomplete (Tinderbox logs are OK). I removed all parts of code related to libpkix.log. If there are data that should not be logged to output.log, please create some new way how to use separate logfile (without touching $LOGFILE).
Assignee: nobody → slavomir.katuscak
Attachment #347265 - Flags: review?(alexei.volkov.bugs)
(Assignee)

Comment 2

9 years ago
Btw, we are not running any tests from libpkix.sh now (because of bug 426510), so it should be only begin message and end message.

Updated

9 years ago
Attachment #347265 - Flags: review?(alexei.volkov.bugs) → review+
(Assignee)

Comment 3

9 years ago
Checking in libpkix.sh;
/cvsroot/mozilla/security/nss/tests/libpkix/libpkix.sh,v  <--  libpkix.sh
new revision: 1.8; previous revision: 1.7
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.