464010 - regexp.test doesn't work on 64 bit linux builds

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Olli Pettay [:smaug][[e-mail]]]

regexp.text doesn't seem to work on 64 bit linux builds, and so location bar is broken.

/foo/.test("bar"); should return false, but causes
Error: /foo/.test is not a function
Source File: javascript:%20/foo/.test("bar");

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Btw, this prevents running *any* tests on 64 bit linux.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I accidentally committed this last night (see the #ifdef at the end):

http://hg.mozilla.org/mozilla-central/rev/e278ccc4fc41

but JS_TRACER should be defined in this case, no?

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: get rid of the ifdef

The ifdef should go regardless of whether it's causing this bug or not..

Comment 4

[Benjamin Smedberg]

jstracer and jit should be off for x86-64.

Is this bug reproducable on mac-ppc also?

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Ah, I missed the "else" in Makefile.in.  Then yeah, this is the problem.

Comment 6

[J. Gatellier]

(In reply to comment #4)
> 
> Is this bug reproducable on mac-ppc also?

Yes same bug on mac ppc today.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in; ideally we'd also rebuild today's x86-64 nightly, but I don't know how to do that just for that one machine..

Comment 9

[Bob Clary [:bc] (inactive)]

this is covered by a number of regexp related tests.

Comment 10

[Bob Clary [:bc] (inactive)]

v 1.9.1, 1.9.2