464184 - [PATCH] Mozootle can now import users.prefs data into database

Status: RESOLVED FIXED

(Webtools Graveyard :: Verbatim, defect)

Description

[Asheesh Laroia]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.3) Gecko/2008101315 Ubuntu/8.10 (intrepid) Firefox/3.0.3
Build Identifier: 

I wrote an extra file for Mozootle that lets it import users.prefs data into the SQLite DB.  

(Is this the right way to be suggesting Mozootle improvements?)

Reproducible: Always

Comment 1

[Asheesh Laroia]

Attachment: Importer

This way of submitting patches is fairly frustrating.

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 347466 [details]
Importer

When I run this I get an error:

$ python import_users_prefs.py pootle.prefs users.prefs 
Traceback (most recent call last):
  File "import_users_prefs.py", line 134, in ?
    main()
  File "import_users_prefs.py", line 26, in main01.mozilla.org
    set_up_db_then_import_users(parsed_prefs, parsed_users)
  File "import_users_prefs.py", line 43, in set_up_db_then_import_users
    import_users(alchemysession, parsed_users)
  File "import_users_prefs.py", line 106, in import_users
    _get_user_attribute(data, user_name, 'viewrows', unicode_me=False, default=10))
  File "import_users_prefs.py", line 62, in try_type
    if value.isnumeric():
AttributeError: 'str' object has no attribute 'isnumeric'

Comment 3

[Wil Clouser [:clouserw]]

> (Is this the right way to be suggesting Mozootle improvements?)

Any suggestion with a patch is the right way :)

> This way of submitting patches is fairly frustrating.

What would make it better?

Comment 4

[Fred Wenzel [:wenzel]]

I don't think Pootle uses user.prefs anymore, correct me if I am wrong and if we still need this bug.

Thanks, anyway, for your work, Asheesh!

Comment 5

[Dwayne Bailey]

The current trunk doesn't use .prefs files but of course older installs do have prefs files that need to be migrated, I think that this bug deals with that situation.