464187 - Make the text inputs in the show_bug edit form grow with the window

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Max Kanat-Alexander]

Right now the text inputs (like Whiteboard, Keywords, etc.) in the edit form are a fixed width. They could easily grow with the window, and then people could type/see more in them. I already fixed this for bmo in bug 452824, it should be easy to bring it upstream.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Comment 2

[Guy Pyrzak]

Comment on attachment 347468 [details] [diff] [review]
v1

>Index: skins/standard/show_bug.css
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/skins/standard/show_bug.css,v
>retrieving revision 1.9
>diff -u -r1.9 show_bug.css
>--- skins/standard/show_bug.css	4 Nov 2008 19:17:02 -0000	1.9
>+++ skins/standard/show_bug.css	11 Nov 2008 06:26:46 -0000
>@@ -7,8 +7,19 @@
>     font-weight: bold;
> }
> 
>+.bz_bug .edit_form {
>+  width: 100%;
>+}
>+.bz_bug .edit_form table {
>+  width: 100%;
>+}
>+.bz_bug .edit_form .text_input {
>+  width: 100%;
>+  min-width: 25em;
min width isn't supported by IE6, not sure if that matters, but I thought it should be known

A few feilds were added as core fields (such as see also) and those do not grow with this patch

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> min width isn't supported by IE6, not sure if that matters, but I thought it
> should be known

  Yeah, I know. IE users can suffer if their windows get tiny. :-)

Comment 4

[Max Kanat-Alexander]

Attachment: v2

Okay, I fixed See Also.

Comment 5

[Guy Pyrzak]

Comment on attachment 358453 [details] [diff] [review]
v2

Summary doesn't streach. Neither does alias, although less sure about that field.

Comment 6

[Max Kanat-Alexander]

Attachment: v3

Okay, this makes the summary field grow, too. I can't quite get the flag requestees to grow and have the rest of the table remain correctly auto-sized, so I haven't done it here. I did, however, fix the alignment of the "Flags" label while I was in that code anyway. That's been bugging me for a while.

Comment 7

[Max Kanat-Alexander]

There was some minor bitrot, which I fixed on checkin.

Checking in skins/standard/show_bug.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/show_bug.css,v  <--  show_bug.css
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.155; previous revision: 1.154
done
Checking in template/en/default/bug/field.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/field.html.tmpl,v  <--  field.html.tmpl
new revision: 1.24; previous revision: 1.23
done

Comment 8

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.4 in bug 494037.