464306 - [he] Create a landing page on mozilla.com/he

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: file to translate

Please translate the attached html file, it will be used on the new landing page for your locale and will help promoting your locale.

It will be hosted at http://www.mozilla.com/YOURLOCALECODE/

You can see how it will look like there:
http://www.mozilla.com/af/

Note that there is a string in the blue header leading to the English site [Visit Mozilla.com (in English)], you can put the translation in the comments of this bug if you prefer to have this string appear translated.

If you have any question or doubt, don't hesitate to ask in this bug.

When you attach your translation to the bug, please attach it as text/plain and not text/html.

Thanks

Comment 1

[Tomer Cohen :tomer]

Please note that it will be a bit tricky, since the page doesn't intended to be mirrored (especially the background wallpaper). I'll do my best making the CSS reasonable. 

Should we open another bug for tracking the CSS part?

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

yes, let's open another bug for the css part, maybe ayman will be interested in helping for arabic.

Would having a different background (maybe the same one but mirrored) help ?

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Please translate this file instead, it is more up to date than the attached file:
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/oc/index.html?revision=19669&content-type=text%2Fplain

Thanks

Comment 4

[Tomer Cohen :tomer]

(In reply to comment #2)
> Would having a different background (maybe the same one but mirrored) help ?

I think that in order not to break the design of the whole site, we should keep the same background, and align the localized text in order it will sit in the right place. It is more complicated from the CSS perspective, but I think it worth it. This is my opinion, anyway.

Comment 5

[(no longer active)]

Mozilla.com in general does not have any support for RTL pages.  Bug 443636 is supposed to track this issue, but we haven't got any response on it since it was filed.  :(

Comment 6

[(no longer active)]

I landed some RTL support in the Persian version of mozilla.com in these revisions:

r19798
r19800
r19802
r19805
r19806
r19807

It was a trial-and-error based process, so make sure to incorporate all of the above revisions if you don't want to get something half-baked (or not working).

A sample of this can be viewed at: <https://fa.www-trunk.stage.mozilla.com/fa>.

There is just one thing I'm not sure how to do.  I uploaded mirrored versions of the background images to <http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/fa/img/tignish/home/>, and I thought that any images in the locale dir would override global images, but apparently that's not the case.  Is there any way to produce mirrored versions of the images?

Comment 7

[Tomer Cohen :tomer]

(In reply to comment #6)
> A sample of this can be viewed at: <https://fa.www-trunk.stage.mozilla.com/fa>.
I'm not sure this is what we expect, as the text overlap the background image. Instead of mirroring everything, I think it will be better to move the RTL'ed text to the left, instead of maintaining a mirrored set of images.

Comment 8

[(no longer active)]

But wouldn't it be kind of odd to move the text to the left side?  Usually on an RTL page, everyone expects the title to appear on the right side, instead of the left side...

BTW, I tried the below and managed to get the RTL image to work:

r19880
r19883

Please check out the mirrored page again.  I think it looks good now.

Comment 9

[Tomer Cohen :tomer]

Attachment: he screenshot

Here is my proposed layout for RTL. I've made it look as much as possible to the regular layout, so only the bullet arrow had to be mirrored.

Comment 10

[Tomer Cohen :tomer]

Attachment: mozilla.com/he/ index.html

Comment 11

[Tomer Cohen :tomer]

Attachment: mozilla.com/he/style/tignish/rtl.css

Comment 12

[Tomer Cohen :tomer]

Attachment: mozilla.com/he/img/tignish/firstrun/link-arrow-rtl.png

Comment 13

[(no longer active)]

I don't think you need to style it this way.  If you set $textdir to 'ltr', some styling gets applied.  For example, the RTL arrow is already handled in landing-page-l10n.css.

Comment 14

[Tomer Cohen :tomer]

(In reply to comment #13)
> I don't think you need to style it this way.  If you set $textdir to 'ltr',
> some styling gets applied.  For example, the RTL arrow is already handled in
> landing-page-l10n.css.

You right. The current Hebrew firstrun page <http://he.www.mozilla.com/he/firefox/3.0.1/firstrun/> has the arrow keys already mirrored. I'll go into it and remove the duplicate parts this weekend. Also, some of the rules in the new file might be good for the firstrun page on the production, as it is currently show the title on top of background image.

Comment 15

[Tomer Cohen :tomer]

Attachment: mozilla.com/he/style/tignish/rtl.css

Previous RTL CSS rules - 

/* from template.css */
[dir="rtl"] #doc {
	text-align: right;
}

/* snip */

#footer-contents[dir=rtl] {
	text-align: right;
}

/* landing-page-l10n.css */

[dir=rtl] #main-content .sub-feature p a {
    background: transparent url(/img/tignish/firstrun/link-arrow-rtl.png) right center no-repeat;
    padding-left: 0;
    padding-right: 12px;
}



a. there are two calls for [dir="rtl"] in template.css and yet another one in landing-page-l10n.css. While both Firefox (Gecko) and Chrome (WebKit) do support anonymous rules, Internet Explorer is not supporting them. Even IE8 don't. We should move most of them to a custom rtl.css file, which should be loaded for every rtl locale. My file do support these rules, but require manual change to every page on RTL locale. Is there a better way to include this file automatically in a per-directory basis? 

b. My previous checkin made a duplication with link-arrow-rtl.png. I'm about to remove that file and place calls only to the global file.

c. If the "Visit Mozilla.com (in English)" string will be translated, we should remove the #header{direction:rtl} rule (or at least place LRM at end of the string) Should I?

d. The other in-product pages (such as security, organic etc.) are still inaccessible. Are we going to place links to them from this file?

Comment 16

[Tomer Cohen :tomer]

The page pushed to mozilla.com/he this evening. Thanks Pascal!

Further talks about the CSS of this and other pages should be in a separated bug.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://he.www.mozilla.com/he/.

Comment 18

[Tomer Cohen :tomer]

We are having some strange CSS display issues for this page on IE6. If anyone here is familiar with IE6 bugs, please advice how to fix it. I hope to get into that this weekend.

Comment 19

[Pascal Chevrel:pascalc (PTO until April 26)]

I have fixed the display bugs for IE6 by adding a couple of rules to your rtl.css. There is just a minor display bug (text overlapping arrow) in the download box for IE 6/7 and Firefox 2 that can wait a couple of days.