Closed Bug 464344 Opened 11 years ago Closed 11 years ago

Deleted events from the server are still shown in Lightning after a refresh (or a restart)

Categories

(Calendar :: Provider: CalDAV, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: lmarcotte, Assigned: dbo)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3
Build Identifier: Lightning 0.9

In calDavCalendar.js, caldav_fetchItemVersions(), we have:

                    var item = { etag: etag,
                                 isNew: false,
                                 locationPath: locationPath,
                                 isInboxItem: (isInboxItem == "true")};

this is wrong since, it should read :

                                  ...
                                  isInBoxItem: (isInboxItem == "true")};

since in caldav_gUIs_oGR(), we read the value with :

                                var wasInBoxItem = thisCalendar.mItemInfoCache[itemToDelete.id].isInBoxItem;



Reproducible: Always

Steps to Reproduce:
1. Create an event in a cached caldav calendar
2. Quit TB
3. Remove it from the server
4. Hit "Reload"
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-calendar1.0+
Note the capital "B" in the dict key... Maybe all "InBox" could be changed to "Inbox" in the code with a simple search & replace...
Ludovic, would you be so kind and propose a trunk patch, too?
Attached patch s/Box/box/gSplinter Review
This patch should correct all boxes :) Depends on patch on bug 458828 in my mq.
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #349323 - Flags: review?(philipp)
Depends on: 458828
Attachment #349323 - Flags: review?(philipp) → review+
Comment on attachment 349323 [details] [diff] [review]
s/Box/box/g

Looks good to me, r=philipp
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/ea5f0657cc8b>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0
I checked this issue with lightning 20081209 and the only the 'restart' part of this bug is fixed, the 'reload' part still exists.

STR:
====

- enable caching and restart thunderbird
- Remove an event form the server via webfront end.
- reload the cached caldav calendar -> the event is furthermore visible.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Andreas, if you do modify events from the web frontend and you refresh from Lightning, do you see the modifications right away?

If not, and the problem you've observed with the deleted events, are likely related to https://bugzilla.mozilla.org/show_bug.cgi?id=463960
Ludovic, your a right. In comment #6 I describe bug 463960.
Andreas, can this bug be marked as fixed again?
Martin, sorry I missed that.

This bug is fixed and verified by comment #6 and #7.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.