464357 - Ctrl+L should work like in ff

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

adds support for the CTRL+L command

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 - adds a .selectAll() call

At some point I think we lost the feature where the URL is selected when the location bar is activated.

This patch is the same as the last, but adds the selectAll back

Comment 3

[(dormant account)]

Comment on attachment 347776 [details] [diff] [review]
patch 2 - adds a .selectAll() call

>+        break;
>+      case "cmd_openLocation":
>+        this.show(UIMODE_URLEDIT);
>+        setTimeout(function () {BrowserUI.updateAutoComplete(true)}, 0);
How about moving call to .updateAutoComplete() into show()?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> (From update of attachment 347776 [details] [diff] [review])
> >+        break;
> >+      case "cmd_openLocation":
> >+        this.show(UIMODE_URLEDIT);
> >+        setTimeout(function () {BrowserUI.updateAutoComplete(true)}, 0);
> How about moving call to .updateAutoComplete() into show()?

We call show(UIMODE_URLEDIT) when making a new tab and we, currently, don't show any autocomplete then.

With all the "new tab" pages happening in FF and other browsers, maybe we should. Madhava?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava - Open a new bug if you want some kind of autocomplete popup when making new tabs. It could be something like the new FF page.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 347776 [details] [diff] [review]
patch 2 - adds a .selectAll() call

Have the click handler use the new command too to avoid duplicating the code?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #6)
> (From update of attachment 347776 [details] [diff] [review])
> Have the click handler use the new command too to avoid duplicating the code?

Done

http://hg.mozilla.org/mobile-browser/rev/e398d5148766

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091002
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/200910002
Fennec/1.0b4