464533 - Successful uploads are returning a blank page

Status: VERIFIED FIXED

(Websites :: communitystore.mozilla.org, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Right now, otherwise successful uploads to https://community-store.authstage.mozilla.com/upload are returning just a blank page.

Comment 1

[Ryan Doherty (:rdoherty)]

Aravind, is there anything in the error logs about uploads?

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Live HTTP Header output

Comment 3

[Ryan Doherty (:rdoherty)]

(In reply to comment #2)
> Created an attachment (id=347830) [details]
> Live HTTP Header output

I'm in yer headerz, stealin yer uploadz.

Comment 4

[Aravind Gottipati [:aravind]]

This is the error in the server logs.

[Wed Nov 12 12:52:12 2008] [error] [client 10.2.81.4] PHP Fatal error:  Call to undefined method Upload::escape() in /data/www/community-store.authstage.mozilla.com/mode
ls/upload.class.php on line 17, referer: https://community-store.authstage.mozilla.com/upload

Comment 5

[Ryan Doherty (:rdoherty)]

Looks like we need an svn up. Should happen soon I think...

Comment 6

[Aravind Gottipati [:aravind]]

[root@mrapp-stage02 community-store.authstage.mozilla.com]# svn up

Fetching external item into 'libs/yadbc'
External at revision 19765.

At revision 19765.


Code checked in?

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Since the SVN up, the reCAPTCHA is now printing out:

"Invalid public key. Make sure you copy and pasted it correctly."

Comment 8

[Aravind Gottipati [:aravind]]

Sorry, I had switched the pub and pvt keys.  Please try now.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #8)
> Sorry, I had switched the pub and pvt keys.  Please try now.

That's fixed; https://community-store.authstage.mozilla.com/colorchooser is now giving me the same blank-page behavior as /upload -- separate bug?

Comment 10

[Aravind Gottipati [:aravind]]

That svn up earlier didn't fetch anything, we probably need to check in code first :)

Comment 11

[Ryan Doherty (:rdoherty)]

(In reply to comment #9)
> (In reply to comment #8)
> > Sorry, I had switched the pub and pvt keys.  Please try now.
> 
> That's fixed; https://community-store.authstage.mozilla.com/colorchooser is now
> giving me the same blank-page behavior as /upload -- separate bug?

Not sure what's going on here. This only happens during the non-ajax flow, correct?

Comment 12

[Ryan Doherty (:rdoherty)]

Aravind, any chance the logs could be auto-synced somewhere we could access them? Then we could debug this without bugging you :)

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Odd; last night, when I posted that comment, /upload was taking me to /colorchooser after uploading an image.  I no longer get that, and instead remain on https://community-store.authstage.mozilla.com/upload with the broken/unimplemented design/design by: content (which I thought was taken care of by bug 461446; are the files not being synchronized from SVN, a la comment 6?)

Comment 14

[Ryan Doherty (:rdoherty)]

(In reply to comment #13)
> Odd; last night, when I posted that comment, /upload was taking me to
> /colorchooser after uploading an image.  I no longer get that, and instead
> remain on https://community-store.authstage.mozilla.com/upload with the
> broken/unimplemented design/design by: content (which I thought was taken care
> of by bug 461446; are the files not being synchronized from SVN, a la comment
> 6?)

The javascript on flow will keep you on /upload. Non-javascript users see /colorchooser when they pick their color and submit after uploading. 

Files are being pulled from svn automatically. Can you upload a screenshot of the broken/unimplemented design/design by: content?

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of broken design/designed by: content

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

I can understand that in the case of "I would like to remain anonymous", the "Design by:" attribution remains blank, but perhaps it would be nice to mark it as anonymous in some way (so it doesn't look like a bug).

Clearly, though, that my uploaded image (http://blog.wired.com/cars/images/2007/10/03/08_lexus_is_f_nm_02.jpg) isn't showing up there is a bug.

Comment 17

[Ryan Doherty (:rdoherty)]

(In reply to comment #16)
> I can understand that in the case of "I would like to remain anonymous", the
> "Design by:" attribution remains blank, but perhaps it would be nice to mark it
> as anonymous in some way (so it doesn't look like a bug).

Just fixed this.

> Clearly, though, that my uploaded image
> (http://blog.wired.com/cars/images/2007/10/03/08_lexus_is_f_nm_02.jpg) isn't
> showing up there is a bug.

Yep, that's a bug. Still working on it :)

Comment 18

[Ryan Doherty (:rdoherty)]

Aravind, the sql in the file install.sql is up to date, looks like the community store db needs to be re-loaded. There isn't anything in there now, so it's ok to blow it away.

Comment 19

[Ryan Doherty (:rdoherty)]

reassigning to Aravind per comment 18

Comment 20

[Aravind Gottipati [:aravind]]

Done.

Comment 21

[Ryan Doherty (:rdoherty)]

Just tested, works :) Thanks Aravind!

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://community-store.authstage.mozilla.com/upload.