464543 - Session Save is not prompted after Add-On is updated, Session Restore doesn't occur.

Status: RESOLVED INCOMPLETE

(Toolkit :: Add-ons Manager, defect)

Description

[mozbugz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3 (.NET CLR 3.5.30729)

After an automatic, or manual, update of an installed add-on, closing the application while multiple tabs are open does not prompt the user "Save Session?" like would normally occur.
As a result, when restarting the application, the previous session is lost.

Reproducible: Always

Steps to Reproduce:
1. Open multiple tabs
2. Update an already installed Add-On
3. Close Firefox - no Session Save is prompted
4. Start Firefox - a new session is started
Actual Results:  
Firefox is started with a fresh session, the previous session is lost.

Expected Results:  
Closing firefox at all times, whether or not Add-Ons were updated during the session, should prompt the user, and save the session.

I consider this a critical bug, because I have come to rely on this feature.
The sessions that a user creates over time, back-forward history, open tabs, etc, can be built up over several hours, and contains much value. Users browsing behavior didn't work this way before 'save session' was available, but their habits have changed because of its availability.
When Firefox just closes and I am expecting to have the chance to save my session of 10 tabs with important pages, I have lost valuable 'work'.

Comment 1

[chimalli]

Same behavior in FF 3.0.8 (and previous versions) in Win vista.
Even if I choose "not to update" when starting FF, it seems that the extension updater deletes the saved session.

Comment 2

[John]

I'm not sure this is exactly the same bug but I've been having trouble with Firefox not restoring saved sessions occasionally.  This has been happening for several months now across several versions.  I'm running Windows XP Pro on an HP laptop.  One possible side effect I've noticed is that when I shutdown windows I get several Firefox icons (perhaps remnants of previous sessions?) on my taskbar but they are blank (no wording).  

Is there any diagnostic mode in Firefox?  Any files that I could send that might help?

Comment 3

[Dave Townsend [:mossop]]

Can you elaborate further on the steps to reproduce? Does step 2 include the restart to finalise the update? How are you closing the Firefox in step 3? If you could provide more precise steps then it would help us reproduce this problem.

Comment 4

[rainpl]

I can confirm this, was wondering for a long time why sometimes when clicking X button or hitting Alt-F4 in browser window I get the message to confirm closing open tabs (which means that session will be lost on next launch). There should be no dialog at all and the session should be saved. 

I spotted an interesting inconsistence in this behavior. When your browser has been launched after updating an extension and you close it by clicking 'X' or hitting Alt-F4 it loses the session information. But when you close it with File->Quit (I'm not sure if it's the right translation, I use localized version) from main menu it *always stores* the session data.

Comment 5

[Dave Townsend [:mossop]]

Better steps to reproduce are required here.