Last Comment Bug 46456 - Cannot drag links into personal toolbar
: Cannot drag links into personal toolbar
Status: VERIFIED FIXED
no eta
:
Product: SeaMonkey
Classification: Client Software
Component: Bookmarks & History (show other bugs)
: Trunk
: All All
: P1 normal with 1 vote (vote)
: mozilla0.9.1
Assigned To: Joe Hewitt (gone)
: Claudius Gayle
Mentors:
: 42692 44413 46457 56609 63753 66416 68584 70839 77416 77417 79959 (view as bug list)
Depends on: 42692 53403
Blocks:
  Show dependency treegraph
 
Reported: 2000-07-25 16:54 PDT by Zach Lipton [:zach]
Modified: 2009-10-15 00:58 PDT (History)
19 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
fix feedback stuff (6.83 KB, patch)
2001-05-02 11:56 PDT, Alec Flett
no flags Details | Diff | Review

Description Zach Lipton [:zach] 2000-07-25 16:54:54 PDT
Mozilla will not allow you to drag links into the personal toolbar as you can 
do in netscape 4 and MISE.
Comment 1 Jeffrey Baker 2000-07-25 17:05:31 PDT
Drop on the toolbar is not supported.  See Pinkerton's comments on bug 21510.
Comment 2 Jeffrey Baker 2000-07-25 17:05:46 PDT
*** Bug 46457 has been marked as a duplicate of this bug. ***
Comment 3 Jeffrey Baker 2000-07-25 17:07:17 PDT
Wait, I am a stupid man.  *Drops* are supported, but not *drags*.  Reopening and
confirming.
Comment 4 Claudius Gayle 2000-07-27 14:33:53 PDT
Edit|Preferences. In the 'Debug' pane under Miscellaneous click on 'Personal Toolbar Drag & Drop (buggy)'
Comment 5 Claudius Gayle 2000-07-27 14:42:20 PDT
I'm not exactly sure what the disposition of bugs like this should be (or if there's a dupe), given the state of toolbar D&D. Pink 
knows though, so I'm reassigning to him and I'll learn from this one.
Comment 6 Mike Pinkerton (not reading bugmail) 2000-07-27 15:59:51 PDT
future
Comment 7 ekrock's old account (dead) 2000-08-04 17:43:40 PDT
Note that an unfortunate side effect of this bug is that if you drag and drop a
bookmark you've created onto the "Bookmarks Toolbar" (which I think is the new
name for what we used to call the Personal Toolbar), the link does get added to
the Bookmarks pulldown menu UI (visible and usable via Bookmarks-->Bookmark
Toolbar-->W3), but not on the Bookmark Toolbar itself, which is confusingly
inconsistent to the user.
Comment 8 Claudius Gayle 2000-08-04 19:15:54 PDT
Eric, you got this error to happen with the pref I mentioned turned off? I am completely unable to reproduce this on any platform.
If this is happening then I would consider it a more significant failure. with m17 branch builds and the 2000080414-m18 builds
Comment 9 Blake Ross 2000-08-05 08:54:35 PDT
I'm confused.  The original bug here is invalid because d&d works if you turn it 
on (and it will be on by default shortly).  I'm away, but per Eric's comment, 
the personal toolbar is now the bookmarks toolbar?
Comment 10 ekrock's old account (dead) 2000-08-05 15:58:53 PDT
Sorry, I was running in the default configuration, which from your comments 
appears to mean that this functionality was disabled. (Didn't know about the 
existence of this pref.) Per your other comments, sounds like this will soon be 
on by default, so I'm closing this as INVALID.
Comment 11 Mike Pinkerton (not reading bugmail) 2000-08-07 10:39:53 PDT
soon be on by default? with all the crashes that we know people will encounter 
futured?
Comment 12 Blake Ross 2000-08-07 14:30:16 PDT
er...which crashes are these?  I know of one, regarding drop-in folders, and 
Ben said he'd get hyatt to take a look.
Comment 13 Rann Bar-On 2000-08-17 12:46:52 PDT
this has never worked for me
Comment 14 jason majors 2000-10-16 18:41:11 PDT
*** Bug 56609 has been marked as a duplicate of this bug. ***
Comment 15 jason majors 2000-10-16 18:41:54 PDT
*** Bug 56609 has been marked as a duplicate of this bug. ***
Comment 16 Claudius Gayle 2000-10-16 21:15:31 PDT
I think this bug as originally reported should be 'futured' but not invalid.
repening.
Comment 17 Eugene Savitsky 2000-10-22 15:39:02 PDT
So will it be enabled by default or not? BTW in is not only Mac...
Comment 18 Mike Pinkerton (not reading bugmail) 2000-10-24 17:02:33 PDT
pushing over to BenG for him to turn this feature back on post ns6.
Comment 19 Jesse Ruderman 2000-11-11 20:06:01 PST
I think this is the same as bug 44413.
Comment 20 Jesse Ruderman 2000-11-11 20:15:31 PST
Adding dependency on bug 56805.
Comment 21 Zach Lipton [:zach] 2000-11-12 10:41:08 PST
*** Bug 44413 has been marked as a duplicate of this bug. ***
Comment 22 Blake Ross 2000-12-26 13:20:53 PST
*** Bug 63753 has been marked as a duplicate of this bug. ***
Comment 23 Peter Lairo 2000-12-26 14:41:37 PST
i turned this feature on in prefs, but it still doesn#t work!!! does it need a
restart???
Comment 24 Peter Lairo 2001-01-10 09:16:41 PST
Nope, this feature definetely doesn't work yet (latest build and milestone0.7).
Any progress so far?
Comment 25 Marcia Knous [:marcia - use ni] 2001-01-12 13:42:23 PST
Netscape Nav triage team: important for daily usage
Comment 26 David Hallowell 2001-01-24 19:05:24 PST
*** Bug 66416 has been marked as a duplicate of this bug. ***
Comment 27 Brian Haskin (Janzert) 2001-02-12 07:12:28 PST
*** Bug 68584 has been marked as a duplicate of this bug. ***
Comment 28 Paul Chen 2001-03-02 16:52:08 PST
Mass moving most of mozilla0.9 bugs to mozilla0.8.1
Comment 29 Gilles Durys 2001-03-04 10:55:41 PST
*** Bug 70839 has been marked as a duplicate of this bug. ***
Comment 30 Paul Chen 2001-04-09 15:09:24 PDT
Reassigning to alecf since he's working on this. Alecf, if this is a dupe of 
another bug on your plate feel free to mark this as such.
Comment 31 Alec Flett 2001-04-13 17:03:30 PDT
*** Bug 42692 has been marked as a duplicate of this bug. ***
Comment 32 Alec Flett 2001-04-18 10:01:40 PDT
unfortunately, I did not even have time to look at this for moz 0.9. Moving to
0.9.1 and maintaining priority.. sorry!
Comment 33 Alec Flett 2001-04-24 13:33:52 PDT
*** Bug 77416 has been marked as a duplicate of this bug. ***
Comment 34 Alec Flett 2001-04-24 13:34:33 PDT
*** Bug 77417 has been marked as a duplicate of this bug. ***
Comment 35 Peter Lairo 2001-04-25 01:33:01 PDT
hight time for keyword: *Mostfreq* - sooo many dupes :)

I would also suggest *nsCatFood* because this is a serious user satisfaction issue.
Comment 36 Alec Flett 2001-04-25 08:05:14 PDT
alright already, I'm working in it.
Please no advocacy in bugs, let's keep the discussion to technical issues!
Comment 37 Alec Flett 2001-05-02 11:56:07 PDT
Created attachment 32901 [details] [diff] [review]
fix feedback stuff
Comment 38 Alec Flett 2001-05-02 11:58:41 PDT
ok, this by no means fixes this bug, but it updates the visual feedback when
you're doing a drag/drop.. the actual drop is somewhat broken.
looking for r=/sr=

A few things this does:
- adds some bulletproofing
- fixes it so that for toolbar bookmarks, you can only drag to the left or
right, but not on top...and for folders you can drag on top, or to the left or right
- adds pleasant visual feedback for these behaviors, such as a 3d outline around
folders that you're dropping onto
- cleans up some of the drag on/after/before stuff so we don't have to know what
magic numbers like "-1" mean and can use constants instead.
Comment 39 Ben Goodger (use ben at mozilla dot org for email) 2001-05-02 13:56:37 PDT
sr=ben@netscape.com
Comment 40 Alec Flett 2001-05-02 16:11:37 PDT
add pink to the CC, I think he's supposed to help me :)
Comment 41 Viswanath Ramachandran 2001-05-02 18:07:39 PDT
Alec, is dragging a URL from the personal toolbar to the bookmarks sidebar tab 
also covered by this? thanks, vishy
Comment 42 Viswanath Ramachandran 2001-05-02 18:09:21 PDT
also, is dragging and dropping within the toolbar (i.e. reordering p toolbar 
elements by dnd) covered by this bug? 
Comment 43 Alec Flett 2001-05-02 19:44:59 PDT
no, and no... 
Comment 44 Viswanath Ramachandran 2001-05-07 16:08:11 PDT
Alec/Pink how's this going? Are we going to make it for mozilla0.9.1 on this? 
Comment 45 Alec Flett 2001-05-07 16:53:48 PDT
I've checked in everything I have and have been focusing on startup performance,
as I explained last week
Comment 46 Mike Pinkerton (not reading bugmail) 2001-05-08 16:17:41 PDT
as i seemed to inherit a slew of critical/crasher bugs while i was on vacation, i 
don't believe i'll have time to help alecf.
Comment 47 Gilles Durys 2001-05-10 06:23:56 PDT
*** Bug 79959 has been marked as a duplicate of this bug. ***
Comment 48 Todd Pringle 2001-05-10 11:52:01 PDT
This is a show stopper, IMO.  Of the complaints about N6, this was one of the
top 3. 
Comment 49 Alec Flett 2001-05-10 13:59:09 PDT
just an update that no progress has been made on this beyond the feedback
itself.. I'm swamped with startup performance work... :( I agree this is an N6.5
rtm stopper, but can we get by nsbeta1 without it?
Comment 50 Mike Pinkerton (not reading bugmail) 2001-05-10 14:02:32 PDT
i'm not sure this is even an rtm stopper. i'd rather we focus development effort 
on fixing speed, stability, and making the features we currently have work before 
we spend more time working on new ones.
Comment 51 Viswanath Ramachandran 2001-05-10 14:12:23 PDT
thanks for the update. yes we're considering postponing to rtm or getting ben to 
work on it. 
Comment 52 ajbu 2001-05-10 14:47:33 PDT
At the moment this is not a feature but a bug because the Personal Toolbar is 
registered as a dropzone, and dragging bookmarks to the toolbar gives visual 
feedback that the bookmark is accepted when dropping it there. If it is 
postponed it would probably be better to turn off the personal toolbar as a 
dropzone.
Comment 53 Eugene Savitsky 2001-05-10 15:18:00 PDT
I would better wait a week for fixing it... Or is the lesson of Netscape 6.0 as
a non complete, bugfull and featureless final release is already forgotten?

Whith this fix we will win another 0.1% of users!!!
Comment 54 Zach Lipton [:zach] 2001-05-14 10:48:23 PDT
Adding helpwanted as per plario's request, though I am going to hold off 
on adding nscatfood, for two reasons:

1. I am not part of netscape, and therefore do not have an interest in nscp 
user satisfaction.
2. IMHO, This is not such a _HUGE_ issue that it is really catfood.
Comment 55 Viswanath Ramachandran 2001-05-14 10:51:51 PDT
ben's going to take this, reassigning to him. 
Comment 56 Asa Dotzler [:asa] 2001-05-14 13:13:19 PDT
This morning's builds had a bug ( bug 80746 ) which may have led to 
a Bugzilla user inadvertantly 
changing this bug from the Assignbed/Accepted status to the New status.  If you 
are the owner of this bug please check to see that it is in the correct Status.  
Thanks.
Comment 57 selmer (gone) 2001-05-14 14:57:30 PDT
At the very least, the dropzone must be turned off if this feature does not work
properly.  I dragged a bookmark into my personal toolbar on my win98 machine at
home and it *erased* all my personal toolbar bookmarks!!!
Comment 58 selmer (gone) 2001-05-14 17:45:33 PDT
This bug should be moved to m0.9.2 in favor of fixing bug 78882 for the beta.
Comment 59 Viswanath Ramachandran 2001-05-15 17:20:33 PDT
nav triage: a tough decision, esp for the PM ( :-) ) but lets defer this to post 
m0.9.1. 
Comment 60 Ben Goodger (use ben at mozilla dot org for email) 2001-05-17 21:11:54 PDT
Joe said he wanted to do this. 
Comment 61 Joe Hewitt (gone) 2001-05-19 23:00:39 PDT
fixed
Comment 62 Viswanath Ramachandran 2001-05-20 23:14:46 PDT
you mean we can now drag links into personal toolbar, or we fixed the problem 
that it drags "null"? 
Comment 63 Joe Hewitt (gone) 2001-05-21 13:46:14 PDT
Yes, you can now drag links into the personal toolbar.
Comment 64 Gilles Durys 2001-05-21 14:31:32 PDT
Is there a bug filled about the removal of the pref ?
Comment 65 Claudius Gayle 2001-05-31 17:37:55 PDT
VERIFIED Fixed with 2001053108 builds on all platforms
Comment 66 xjahn 2001-08-08 18:59:59 PDT
Unable to drag URL to toolbar in 0.9.3
You CAN drag into a FOLDER on the toolbar, however.
Comment 67 Jacek Piskozub 2001-08-09 13:27:28 PDT
Marking mosfreq (14 dups)
Comment 68 Blake Ross 2001-08-17 16:27:48 PDT
This works fine for me. Please retest.
Comment 69 Eugene Savitsky 2001-08-17 17:44:00 PDT
I there a bug for DnD to choosed location in a folder on the personal toolbar
(not to the bottom of it)?

Also right-click menu inside a folder to edit/rename/remove etc the bookmark
(works on the personal toolbar bookmark, but not inside a folder) does not exists.

I was surprised since I couldn't find bugs for this major Personal Toolbar
features...

Should I fillthe bugs or there already bugs for it?
Comment 70 Jesse Ruderman 2001-08-21 19:07:52 PDT
>I there a bug for DnD to choosed location in a folder on the personal toolbar
>(not to the bottom of it)?

bug 53707, RFE: dragging a link onto bookmarks button should open menu

>Also right-click menu inside a folder to edit/rename/remove etc the bookmark
>(works on the personal toolbar bookmark, but not inside a folder) does not 
>exists.

Bug 50504, Context menu for bookmarks menus

You should be able to find any other related bugs using dependency trees or 
collect buglinks <http://www.squarefree.com/bookmarklets/mozilla.html> on those 
two bugs.
Comment 71 Jens Schürmann 2002-02-17 13:56:13 PST
Return of......   a BUG !!!!!!!

When I drag a Link into the Personal Toolbar, it disapears !!

I use Mozilla 0.9.8 .
It didn't even works when I install Mozilla after a total deinstall!
Comment 72 selmer (gone) 2002-02-18 13:19:12 PST
This apparently still happens for some profiles, probably because of something
that happened using a prior version of the product.  Jens, can you try it in a
new profile and see if that fixes it?  If so, it's probably better to open a new
bug so we can try to figure out what's unique about the failing profile. 
(Elaine King also experiences this problem with current builds.)

Note You need to log in before you can comment on or make changes to this bug.


Privacy Policy