[redux] Assertion failure in core/Bitset.h:244 on win64 shell

VERIFIED FIXED

Status

VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: brbaker, Assigned: stejohns)

Tracking

({flashplayer})

unspecified
x86
Windows XP
flashplayer
Bug Flags:
in-testsuite +
wanted-flashplayer10 +
flashplayer-triage +

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
The following testcases are currently producing assertion failures in the debug and debug_debugger shells on windows64, build #1095

as3/Definitions/Classes/ClassDef/FinalInternalClass.abc
as3/Definitions/Classes/ClassDef/PublicClass.abc
as3/Definitions/Classes/ClassDef/PublicDynamicClass.abc
as3/Definitions/FunctionAccessors/GetSetDiffScope.abc

avmplus crash: exception 0x80000003 occurred
Writing minidump crash log to avmplusCrash.dmp
Assertion failed: "((bit < m_cap))" ("c:\\buildbot\\tamarin-redux\\windows64\\tamarin-redux\\core\\BitSet.h":244)
Flags: wanted-flashplayer10+
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb?

Updated

10 years ago
Assignee: nobody → edwsmith

Comment 1

10 years ago
assert is at Traits.cpp:2613, in destroyInstance().  On a 64b machine the bitmask appears to be one bit smaller than required.

Updated

10 years ago
Assignee: edwsmith → stejohns
(Assignee)

Comment 2

10 years ago
ah, problem is actually that slotSize is being calculated slightly differently in the two places -- one does rounding-up for 64 bit systems, other does not. fix forthcoming.
(Assignee)

Comment 3

10 years ago
Created attachment 348094 [details] [diff] [review]
Patch

Pad slotSize appropriately for 64-bit builds.
Attachment #348094 - Flags: review?(edwsmith)
(Reporter)

Comment 4

10 years ago
I tested the patch in the sandbox and all of the windows64 acceptance runs passed with no assertions.

http://tamarin-builds.mozilla.org/sandbox/builders/windows64/builds/54

Comment 5

10 years ago
Comment on attachment 348094 [details] [diff] [review]
Patch

less ifdefs required if you use

    (sizeof(uintptr_t)-1)

instead of 3 or 7 in your rounding expressions.
Attachment #348094 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 6

10 years ago
Doh. Yeah. I'll correct that before pushing.
(Assignee)

Comment 7

10 years ago
pushed to redux as changeset:   1101:c94aade317be
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Updated

9 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Comment 8

9 years ago
removing QRB request, bug resolved/verified
Flags: flashplayer-qrb?
You need to log in before you can comment on or make changes to this bug.