464661 - [redux] Assertion failure in core/Bitset.h:244 on win64 shell

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Brent Baker]

The following testcases are currently producing assertion failures in the debug and debug_debugger shells on windows64, build #1095

as3/Definitions/Classes/ClassDef/FinalInternalClass.abc
as3/Definitions/Classes/ClassDef/PublicClass.abc
as3/Definitions/Classes/ClassDef/PublicDynamicClass.abc
as3/Definitions/FunctionAccessors/GetSetDiffScope.abc

avmplus crash: exception 0x80000003 occurred
Writing minidump crash log to avmplusCrash.dmp
Assertion failed: "((bit < m_cap))" ("c:\\buildbot\\tamarin-redux\\windows64\\tamarin-redux\\core\\BitSet.h":244)

Comment 1

[Edwin Smith]

assert is at Traits.cpp:2613, in destroyInstance().  On a 64b machine the bitmask appears to be one bit smaller than required.

Comment 2

[Steven Johnson]

ah, problem is actually that slotSize is being calculated slightly differently in the two places -- one does rounding-up for 64 bit systems, other does not. fix forthcoming.

Comment 3

[Steven Johnson]

Attachment: Patch

Pad slotSize appropriately for 64-bit builds.

Comment 4

[Brent Baker]

I tested the patch in the sandbox and all of the windows64 acceptance runs passed with no assertions.

http://tamarin-builds.mozilla.org/sandbox/builders/windows64/builds/54

Comment 5

[Edwin Smith]

Comment on attachment 348094 [details] [diff] [review]
Patch

less ifdefs required if you use

    (sizeof(uintptr_t)-1)

instead of 3 or 7 in your rounding expressions.

Comment 6

[Steven Johnson]

Doh. Yeah. I'll correct that before pushing.

Comment 7

[Steven Johnson]

pushed to redux as changeset:   1101:c94aade317be

Comment 8

[Brent Baker]

removing QRB request, bug resolved/verified