464727 - Incorrect linkification of view-source if newline follows the linkinfied attribute.

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See attachment.  View its source, and look at the links.  Copy the link locations and paste them into a text editor.

The view-source links seem to include everything to the end of line in the link, including the close-quote and the whitespace.  They should only include the attribute value.

Not sure whether we want to block on this, but it's making this feature pretty useless on a lot of pages for me...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: The testcase

Comment 2

[Curtis Bartley [:cbartley]]

Attachment: Trim function was not checking for newline in attribute values.

The attribute trimming code was checking for tab twice and newline never.  Now it will only check for tab once and will check for newline too.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348018 [details] [diff] [review]
Trim function was not checking for newline in attribute values.

a=beltzner; sheriffs, this patch is safe to take along with any other checkin

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed changeset 6fee12207f39