Closed Bug 464791 Opened 13 years ago Closed 13 years ago

Add ifdef MOZ_UPDATER for the app update preferences UI and Help menu

Categories

(Firefox :: Preferences, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.1b3

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files, 2 obsolete files)

If Firefox is compiled with --disable-updater the app update preferences UI should not be displayed.
Attached patch patch rev1 (obsolete) — Splinter Review
As we discussed
Attachment #348072 - Flags: review?(mconnor)
Attachment #348072 - Flags: review?(mconnor) → review+
Flags: blocking-firefox3.1+
Flags: blocking-firefox3.1+
Comment on attachment 348072 [details] [diff] [review]
patch rev1

bah... I only checked that the js file was preprocessed correctly and just noticed that the cul file isn't. I think I have a fix and will resubmit
Attachment #348072 - Attachment is obsolete: true
Attached patch patch in progress rev1 (obsolete) — Splinter Review
This approach would require splitting out the timer manager... need to think about it a bit.
Attachment #348158 - Flags: review?(mconnor)
Comment on attachment 348158 [details] [diff] [review]
patch in progress (just browser changes) rev2

I'd prefer just removing the separator for the update check menuitem but safebrowsing uses it. :(
Attachment #348157 - Attachment is obsolete: true
Attachment #348158 - Flags: review?(mconnor) → review+
Comment on attachment 348158 [details] [diff] [review]
patch in progress (just browser changes) rev2

looks good.
Attachment #348158 - Flags: approval1.9.1?
Attachment #348158 - Flags: approval1.9.1? → approval1.9.1+
Summary: Add ifdef MOZ_UPDATER for the app update preferences UI → Add ifdef MOZ_UPDATER for the app update preferences UI and Help menu
Pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/fbac619d52fedfa1e1de33b44b723625ad69b183
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b3
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.