Closed Bug 464880 Opened 13 years ago Closed 12 years ago

Shift-Tab does not move the focus backwards

Categories

(Core Graveyard :: Widget: Qt, defect)

x86
Linux
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: steffen.imhof, Assigned: steffen.imhof)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko
Build Identifier: MOZILLA_VERSION 1.9.1b2pre

Pressing Tab moves the focus forward as expected, but Shift-Tab does not move it at all.

Reproducible: Always

Steps to Reproduce:
1. Go to a website with multiple focusable elements (links, input fields, ..)
2. Try to move the focus with Shift-Tab
Actual Results:  
Nothing happens

Expected Results:  
Focus should move backwards in the tab-order.
The cause of the problem is, that Qt has a special virtual key code for "Backtab" which is not mapped to a NS_VK_* code. The patch adds a line to nsQtKeyUtils.cpp that maps it to NS_VK_TAB. It seems this should be ok, because the shift-state is handled extra anyway.
Comment on attachment 348163 [details] [diff] [review]
Patch to map Qt::Key_Backtab to NS_VK_TAB

Works fine for me
Attachment #348163 - Flags: review+
Comment on attachment 348163 [details] [diff] [review]
Patch to map Qt::Key_Backtab to NS_VK_TAB

I'm not sure is it ok to have my review for such patches? or I always need get review from someone else?
Attachment #348163 - Flags: review?(vladimir)
Is there anything that could be done to get this patch accepted?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #348163 - Flags: review?(vladimir) → review+
Whiteboard: checkin-needed
Assignee: nobody → steffen.imhof
http://hg.mozilla.org/mozilla-central/rev/821dba792e8c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed
Target Milestone: --- → mozilla1.9.2a1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.