464880 - Shift-Tab does not move the focus backwards

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Steffen Imhof]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko
Build Identifier: MOZILLA_VERSION 1.9.1b2pre

Pressing Tab moves the focus forward as expected, but Shift-Tab does not move it at all.

Reproducible: Always

Steps to Reproduce:
1. Go to a website with multiple focusable elements (links, input fields, ..)
2. Try to move the focus with Shift-Tab
Actual Results:  
Nothing happens

Expected Results:  
Focus should move backwards in the tab-order.

Comment 1

[Steffen Imhof]

Attachment: Patch to map Qt::Key_Backtab to NS_VK_TAB

The cause of the problem is, that Qt has a special virtual key code for "Backtab" which is not mapped to a NS_VK_* code. The patch adds a line to nsQtKeyUtils.cpp that maps it to NS_VK_TAB. It seems this should be ok, because the shift-state is handled extra anyway.

Comment 2

[Oleg Romashin (:romaxa)]

Comment on attachment 348163 [details] [diff] [review]
Patch to map Qt::Key_Backtab to NS_VK_TAB

Works fine for me

Comment 3

[Oleg Romashin (:romaxa)]

Comment on attachment 348163 [details] [diff] [review]
Patch to map Qt::Key_Backtab to NS_VK_TAB

I'm not sure is it ok to have my review for such patches? or I always need get review from someone else?

Comment 4

[Tobias Hunger]

Is there anything that could be done to get this patch accepted?

Comment 5

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/821dba792e8c