464969 - Edit message as new adds "=" characters to text for signed multipart alternative quoted printable messages

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Michael Baffoni]

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1b2pre) Gecko/20081114 Shredder/3.0b1pre

Steps to reproduce:
1) Select a message from the sent folder (might work in other folders, tested only in sent)
2) Messages->edit message as new

Expected results:
3) Compose window should show content exactly as originally composed

Actual results:
3) Compose window shows content with "= " littered throughout the text.  

I don't believe these are text breaks for sending when in text mode, I edit in HTML mode and I have it configured to always send in HTML; also, I see them in places that would not be a text break (e.g. in my html signature), so not sure what is going on.

Comment 1

[Magnus Melin [:mkmelin]]

Quoted-printable use those yes. 
Did this just start happening? (If so, mark it as regression, blocking bug 307023).

Comment 2

[rsx11m]

Do you have mail.strictly_mime set "true" if this is your own message, or
are you trying to edit a message received in quoted-printable format?

Comment 3

[Michael Baffoni]

RE: Comment#1: It may or may not have happened in prior versions (I hadn't noticed this), but it did appear after installing today's nightly.  Where do I mark this as regression?

RE: Comment#2:  No, I do not have that setting enabled, it is default/false.   This was on my own message created an hour prior.

Comment 4

[Magnus Melin [:mkmelin]]

There's a "regression" keyword. Only set it if you know the behavior changed for the worse compared to a previous build.

Comment 5

[David :Bienvenu]

it sounds like a regression from the fix for bug 307023, but I don't see the problem here. Do you have a sample message that shows the problem?

Comment 6

[Michael Baffoni]

Attachment: This is the original email, before editing

This is the original email, before editing

Comment 7

[Michael Baffoni]

Attachment: This is the edited email, after editing as new

This is the edited email, after editing as new

Comment 8

[David :Bienvenu]

this is a signed multipart alternative quoted printable message.

Comment 9

[Michael Baffoni]

RE Comment 8: You are correct.

Per request on bug 464969, this bug does not appear on 11/11 build, but does appear on 11/12 build.

Comment 10

[David :Bienvenu]

yes, I was trying to fix a bug where we were decoding the same part multiple times. I was worried that my fix might make us not decode some parts at all, which sounds like what happened - I assume you're seeing things like =32, =20, etc, in your message?

Comment 11

[Michael Baffoni]

Actually, all I would "see" is the "= " in the message view, but looking at the message source, I see a bunch of "=3d" thrown into the source, mostly in the text version, and in the meta headers of the HTML (e.g. charset=3D"3DISO-885=3D" 9-1=3D"") - the HTML for the link of my website is really odd: "<a class=3D"moz-txt-link-abbreviated" href=3D"http://www.avinc.com">www.avinc.com</a><br>" " became "</a><a class=3D"3D&quot;moz-txt-link-abbreviated&quot;"
 href=3D"3D%22http://www.avinc.com%22">www.a=3Dvinc.com</a><br>

Comment 12

[Magnus Melin [:mkmelin]]

Linux too - tested with attachment 348262 [details]

Comment 13

[rsx11m]

(In reply to comment #2)
> Do you have mail.strictly_mime set "true" if this is your own message, or
> are you trying to edit a message received in quoted-printable format?

It appears that signed messages always end up with a q-p encoding, suggested
by what was described in bug 464445 on branch (thus, pre-307023 behavior).

Comment 14

[David :Bienvenu]

this should be fixed by backing out the fix for 307023