464974 - Add "closed tree" hook to mozilla-central

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Johnathan Nightingale [:johnath]]

Now that we have landed the treeclosure.py hook in bug 458172, the next step is to wire it up to mozilla-central.

It's a pretxnchangegroup, so this should just mean adding:

pretxnchangegroup = python:mozhghooks.treeclosure.hook

to the [hooks] section.  But you knew that.

Gonna write a dev.planning note about this too, in case anyone thinks of a reason it shouldn't be done - but it's pretty easy to flip on and off, so I don't really think we should block this bug on that discussion...

Comment 1

[Johnathan Nightingale [:johnath]]

There seems to be broad agreement on the dev.planning thread so far.  Let's do it.

Comment 2

[Aravind Gottipati [:aravind]]

how is it enabled?  I am guessing it needs IT intervention everytime this needs to be activated?  Also, does it turn on automatically once I add it to the hooks section?

Comment 3

[Johnathan Nightingale [:johnath]]

(In reply to comment #2)
> how is it enabled?  I am guessing it needs IT intervention everytime this needs
> to be activated?  Also, does it turn on automatically once I add it to the
> hooks section?

No IT intervention needed - it scrapes the tinderbox page (which sheriffs already update to signal a closed tree) and in every case except where it finds "CLOSED" in the span tag it is looking at, it lets the checkin through.

It's live as soon as you add it to the hgrc.

Comment 4

[Aravind Gottipati [:aravind]]

Done.