Closed Bug 465032 Opened 13 years ago Closed 13 years ago

operationCount as the first field in JSContext

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: igor, Assigned: igor)

Details

(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

JSContext.operationCount is one of the most frequently used fields in JSContext code-wise and, at least for scripts with tight loops, the most frequently accessed fields of JSContext runtime-wise. Thus we should consider making it at the first field in JSContext. See bug 450000 comment 61 - 64.
OS: Mac OS X → All
Hardware: PC → All
Attached patch fix v1 (obsolete) — Splinter Review
The patch moves the operationCount field to the first position in JSContext and adjust JSCList-to-JSContext conversion code accordingly.
Attachment #348554 - Flags: review?(brendan)
Attached patch fix v2Splinter Review
The new version name JSCList-to-JSContext conversion function as js_ContextFromLinkField. The former name js_ThreadLinkToContext is wrong as JSContext.link has nothing to do with threads.
Attachment #348554 - Attachment is obsolete: true
Attachment #348555 - Flags: review?(brendan)
Attachment #348554 - Flags: review?(brendan)
Attachment #348555 - Flags: review?(brendan)
Attachment #348555 - Flags: review+
Attachment #348555 - Flags: approval1.9.1b2?
Attachment #348555 - Flags: approval1.9.1b2? → approval1.9.1?
Comment on attachment 348555 [details] [diff] [review]
fix v2

Spoke with brendan, should be ok to take this post-b2
Comment on attachment 348555 [details] [diff] [review]
fix v2

a191=beltzner
Attachment #348555 - Flags: approval1.9.1? → approval1.9.1+
Whiteboard: fixed-in-tracemonkey
merged to mc
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.