operationCount as the first field in JSContext

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

({fixed1.9.1})

unspecified
fixed1.9.1
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 1 obsolete attachment)

4.44 KB, patch
brendan
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
JSContext.operationCount is one of the most frequently used fields in JSContext code-wise and, at least for scripts with tight loops, the most frequently accessed fields of JSContext runtime-wise. Thus we should consider making it at the first field in JSContext. See bug 450000 comment 61 - 64.
(Assignee)

Updated

10 years ago
OS: Mac OS X → All
Hardware: PC → All
(Assignee)

Comment 1

10 years ago
Created attachment 348554 [details] [diff] [review]
fix v1

The patch moves the operationCount field to the first position in JSContext and adjust JSCList-to-JSContext conversion code accordingly.
Attachment #348554 - Flags: review?(brendan)
(Assignee)

Comment 2

10 years ago
Created attachment 348555 [details] [diff] [review]
fix v2

The new version name JSCList-to-JSContext conversion function as js_ContextFromLinkField. The former name js_ThreadLinkToContext is wrong as JSContext.link has nothing to do with threads.
Attachment #348554 - Attachment is obsolete: true
Attachment #348555 - Flags: review?(brendan)
Attachment #348554 - Flags: review?(brendan)

Updated

10 years ago
Attachment #348555 - Flags: review?(brendan)
Attachment #348555 - Flags: review+
Attachment #348555 - Flags: approval1.9.1b2?
Attachment #348555 - Flags: approval1.9.1b2? → approval1.9.1?
Comment on attachment 348555 [details] [diff] [review]
fix v2

Spoke with brendan, should be ok to take this post-b2
Comment on attachment 348555 [details] [diff] [review]
fix v2

a191=beltzner
Attachment #348555 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Updated

10 years ago
Whiteboard: fixed-in-tracemonkey

Comment 5

10 years ago
merged to mc
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.