Closed
Bug 465032
Opened 16 years ago
Closed 16 years ago
operationCount as the first field in JSContext
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
Details
(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
4.44 KB,
patch
|
brendan
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
JSContext.operationCount is one of the most frequently used fields in JSContext code-wise and, at least for scripts with tight loops, the most frequently accessed fields of JSContext runtime-wise. Thus we should consider making it at the first field in JSContext. See bug 450000 comment 61 - 64.
|
Assignee | |
Updated•16 years ago
|
OS: Mac OS X → All
Hardware: PC → All
|
|
Assignee | |
Comment 1•16 years ago
|
||
The patch moves the operationCount field to the first position in JSContext and adjust JSCList-to-JSContext conversion code accordingly.
Attachment #348554 -
Flags: review?(brendan)
|
|
Assignee | |
Comment 2•16 years ago
|
||
The new version name JSCList-to-JSContext conversion function as js_ContextFromLinkField. The former name js_ThreadLinkToContext is wrong as JSContext.link has nothing to do with threads.
Attachment #348554 -
Attachment is obsolete: true
Attachment #348555 -
Flags: review?(brendan)
Attachment #348554 -
Flags: review?(brendan)
|
||
Updated•16 years ago
|
Attachment #348555 -
Flags: review?(brendan)
Attachment #348555 -
Flags: review+
Attachment #348555 -
Flags: approval1.9.1b2?
|
||
Updated•16 years ago
|
Attachment #348555 -
Flags: approval1.9.1b2? → approval1.9.1?
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 348555 [details] [diff] [review] fix v2 Spoke with brendan, should be ok to take this post-b2
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 348555 [details] [diff] [review] fix v2 a191=beltzner
Attachment #348555 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•16 years ago
|
||
merged to mc
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•16 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9beb7f5a726a
Keywords: fixed1.9.1
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•