465066 - Geolocation MaemoLocationProvider.cpp compilation fail due missing includes

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect, P3)

Description

[Oleg Romashin (:romaxa)]

Attachment: Build fix

MaemoLocationProvider.cpp: In member function `virtual nsresult nsGeoPosition::QueryInterface(const nsIID&, void**)':
MaemoLocationProvider.cpp:68: error: `GeoPosition' undeclared (first use this function)
MaemoLocationProvider.cpp:68: error: (Each undeclared identifier is reported only once for each function it appears in.)
MaemoLocationProvider.cpp:68: error: `NS_DOM_INTERFACE_MAP_ENTRY_CLASSINFO' undeclared (first use this function)
MaemoLocationProvider.cpp:69: error: expected `;' before "foundInterface"
MaemoLocationProvider.cpp: In function `void location_changed(LocationGPSDevice*, void*)':
MaemoLocationProvider.cpp:151: warning: passing `double' for converting 8 of `nsGeoPosition::nsGeoPosition(double, double, double, double, double, double, double, long long int)

Comment 1

[Doug Turner (:dougt)]

romaxa, why am I not seeing this?

Comment 2

[Oleg Romashin (:romaxa)]

Not sure, may be I was using dirfferent compiler with strict options..

Comment 3

[Oleg Romashin (:romaxa)]

Pushed in:
http://hg.mozilla.org/mozilla-central/rev/7ddc87fb7b4c

Comment 4

[Doug Turner (:dougt)]

could you also land on 1.9.1?

Comment 5

[Oleg Romashin (:romaxa)]

Should I have some flag about landing to 1.9.1?
Also which branch should I use ?

Comment 6

[Doug Turner (:dougt)]

this is maemo only.  you should be able to land this on the 1.9.1 branch without any additional permission.

Comment 7

[Oleg Romashin (:romaxa)]

I hope this is the right branch... GECKO191b2_20081125_RELBRANCH

Comment 8

[Oleg Romashin (:romaxa)]

It is already there:
https://hg.mozilla.org/releases/mozilla-1.9.1/rev/75e2dd630582

Comment 9

[Doug Turner (:dougt)]

thanks romaxa!