Closed
Bug 465111
Opened 17 years ago
Closed 14 years ago
non-inlined float domain conversions should match inlined
Categories
(Core :: Graphics: Color Management, defect)
Core
Graphics: Color Management
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: bholley, Assigned: jrmuizel)
References
Details
From dbaron on bug 445552:
In lcms.h, #ifdef USE_INLINE:
>+LCMS_INLINE int FromFloatDomain(FLOAT a) { return (int) (a * 65536.0f + 0.5f); }
In cmsmtrx.c, #ifndef USE_INLINE:
>+int FromFloatDomain(Float a)
>+{
>+ return (int) (a * 65536f);
>+}
Shouldn't these two versions of FromFloatDomain be the same?
Marking as minor since we never use the non-inlined version.
Component: GFX → GFX: Color Management
QA Contact: general → color-management
Version: unspecified → Trunk
|
Reporter | |
Comment 1•16 years ago
|
||
Jeff, this is no longer an issue with QCMS right?
Assignee: bobbyholley → jmuizelaar
|
Assignee | |
Comment 2•16 years ago
|
||
Well the sse code rounds differently then the c code, so yes and no...
|
||
Comment 3•14 years ago
|
||
We don't use LCMS any more, so I'm just going to call this incomplete and move on. If we want rounding to be the same between C and SSE in QCMS, we should file a new bug.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•