non-inlined float domain conversions should match inlined

RESOLVED INCOMPLETE

Status

()

--
minor
RESOLVED INCOMPLETE
10 years ago
7 years ago

People

(Reporter: bholley, Assigned: jrmuizel)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
From dbaron on bug 445552:

In lcms.h, #ifdef USE_INLINE:
>+LCMS_INLINE int     FromFloatDomain(FLOAT a)  { return (int) (a * 65536.0f + 0.5f); }   

In cmsmtrx.c, #ifndef USE_INLINE:
>+int FromFloatDomain(Float a)
>+{
>+    return (int) (a * 65536f); 
>+}   

Shouldn't these two versions of FromFloatDomain be the same?

Marking as minor since we never use the non-inlined version.

Updated

10 years ago
Component: GFX → GFX: Color Management
QA Contact: general → color-management
Version: unspecified → Trunk
(Reporter)

Comment 1

9 years ago
Jeff, this is no longer an issue with QCMS right?
Assignee: bobbyholley → jmuizelaar
(Assignee)

Comment 2

9 years ago
Well the sse code rounds differently then the c code, so yes and no...
We don't use LCMS any more, so I'm just going to call this incomplete and move on. If we want rounding to be the same between C and SSE in QCMS, we should file a new bug.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.