Closed Bug 465265 Opened 16 years ago Closed 15 years ago

Support swipe gestures in View Source windows on Mac OS X

Categories

(Toolkit :: View Source, enhancement)

All
macOS
enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.3a1

People

(Reporter: tom.dyas, Assigned: tom.dyas)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081116 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081116 Minefield/3.1b2pre

Support for multi-touch gestures was recently added to Firefox.  The View Source window should take advantage of that support.

Reproducible: Always
Version: unspecified → Trunk
Attached patch View Source - Swipe Support v1 (obsolete) — Splinter Review
This patch adds basic support in the View Source window for the three-fingered swipe gestures available on recent Macintosh laptops.  The responses have been hardcoded as follows: left - back, right - forward, up - scroll to top, and down - scroll to bottom.  I can make these responses configurable through options in a similar manner to the existing gestures support (gGestureSupport) in browser/base/content/browser.js if that is wanted.
Attachment #348513 - Flags: ui-review?(beltzner)
Attachment #348513 - Flags: review?(gavin.sharp)
Status: UNCONFIRMED → NEW
Ever confirmed: true
This patch waits still for a while. Any chance to get it reviewed?
Status: NEW → ASSIGNED
Component: General → View Source
Product: Firefox → Toolkit
QA Contact: general → view.source
Hardware: PowerPC → All
Whiteboard: [has patch][needs ui-review beltzner][needs review gavin]
Assignee: nobody → tdyas
Attachment #348513 - Flags: review?(gavin.sharp) → review+
It really seems like not having this capability in source windows is an UI/HCI inconsistency within the browser.  I filed bug 483456 about the same issue before noticing this one and having it marked as a duplicate.
Tom, can we ask Alex for ui-review?
Whiteboard: [has patch][needs ui-review beltzner][needs review gavin] → [has patch][needs ui-review beltzner]
Just wanted to say that Tom's patch works great for me.  It was my first time meddling with the Firefox source and I was pleasantly surprised to find this portion a just a matter of changing some JavaScript source and repackaging.
It's been almost a year since the patch got an r+ but no ui-review.  Who should handle UI review?
According to http://www.mozilla.org/projects/toolkit/review.html your choices for toolkit ui-r are beltzner and mconnor, so, um, good luck with that.
Can they delegate to someone else, I wonder?  A year delay is not very encouraging to third party contributors!
Comment on attachment 348513 [details] [diff] [review]
View Source - Swipe Support v1

I'll try to get the review done tomorrow.
Attachment #348513 - Flags: ui-review?(beltzner) → ui-review?(faaborg)
Remade the patch so it applies to the latest trunk checkout.
Attachment #348513 - Attachment is obsolete: true
Attachment #348513 - Flags: ui-review?(faaborg)
Attachment #410585 - Flags: ui-review?(faaborg)
(In reply to comment #10)
> (From update of attachment 348513 [details] [diff] [review])
> I'll try to get the review done tomorrow.

Thanks.
I'm trying to confirm that I can in fact do toolkit ui-reviews (right now I am only listed for Firefox)
Comment on attachment 410585 [details] [diff] [review]
View Source - Swipe Support v1.1

I don't have a new macbook to test this on, but giving a ui-r+ based on described functionality.  Also cc'ing Bryan to make sure this won't cause any unexpected problems over with Thunderbird.
Attachment #410585 - Flags: ui-review?(faaborg) → ui-review+
Bryan: this change sound ok for Thunderbird?  Based on bug 461500 comment #44 I get the impression that you are eager to add support for some of the new gestures.
Whiteboard: [has patch][needs ui-review beltzner] → [has patch]
Actually, this sounds like it is view source window specific, in which case I actually don't know how many other apps are using our view source window, but I don't see any obvious reason this would cause problems for them.
http://hg.mozilla.org/mozilla-central/rev/b34fa3aa96d7
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch]
Target Milestone: --- → mozilla1.9.3a1
(In reply to comment #15)
> Bryan: this change sound ok for Thunderbird?  Based on bug 461500 comment #44 I
> get the impression that you are eager to add support for some of the new
> gestures.

TB uses the view source window for mail messages source so the up and down swipe will help.  We don't have links (AFAIK) in the mail message source so I don't think the back forward will effect us.  Thanks!
Probably more significant than our lack of links is our lack of history, but BrowserBack() and BrowserForward() are both in try/catches, so we'll just always get the swallowed exception that Fx will only get when you swipe to go back or forward when there's no more back or forward to go, and we shouldn't need to stick in any isHistoryEnabled() checks.
Verified fixed on trunk with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091108 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20091108045014

Tom, would this patch be ready for 1.9.2 so we could ask for approval?
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: