465305 - Save page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Comment 1

[Madhava Enros [:madhava]]

It's worth thinking about what use-case this serves, I think.  Why do we think that users will be saving pages on their mobile devices?

- is it to keep being able to use a page's content when they're out of network range?  would a "use this page while offline?" option be better?

- is it to save something like a boarding pass or receipt?  (maybe this is just a subcase of the first one) -- something like save as PDF might be more appropriate?

Comment 2

[Christian Sejersen]

What I had in mind was to be able to access a page while offline and something that is a one-time URL like you mentioned e.g. boarding pass, receipts, confirmations for posted data, etc.

Comment 3

[Juha Seppänen]

Save page as PDF would be best use case in mobile devices so that the you can get "hard" copy of pages such as tickets, boarding passes etc. Also sharing of saved pages via email or via some service would make sense.

Comment 4

[Madhava Enros [:madhava]]

For the addition of this item to the site menu, let's use

"Save as PDF"

for the menu item.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: wip

This wip add a new action in the site menu to "print" a document as PDF.

bug 162659#c51 give me doubt about the fact that this simply works as if on device because of the lack of installed printer(s).

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 434748 [details] [diff] [review]
wip

>diff -r 3bca60979f8e chrome/content/browser-ui.js

>+  _savePageAsPDF: function saveAsPDF() {
>+    let content = getBrowser().contentWindow;

Can we call this "contentWindow"? There is a special "content" property I don't want to confuse. And use "Browser.selectedBrowser" instead of getBrowser(). I'd like to remove getBrowser() someday.

>+    let nsIFilePicker = Components.interfaces.nsIFilePicker;

Remove this line. We can use "Ci.nsIFilePicker" just as easily

>+    let picker = Components.classes["@mozilla.org/filepicker;1"].createInstance(nsIFilePicker);

Use Cc and Ci.nsIFilePicker

>+    // XXX change that
>+    picker.init(window, "Save As PDF", nsIFilePicker.modeSave);
>+    picker.appendFilter("PDF", "*.pdf");
>+    picker.defaultExtension = "pdf";
>+    picker.defaultString = content.document.title;

Also, when testing this on my N900, the filename did not have ".pdf" appended by the file picker. You might want to manually append it yourself.

>+    let webBrowserPrint = content.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
>+                                 .getInterface(Components.interfaces.nsIWebBrowserPrint);
>+
>+    let PSSVC = Components.classes["@mozilla.org/gfx/printsettings-service;1"]
>+                          .getService(Components.interfaces.nsIPrintSettingsService);

More Cc and Ci

>+
>+    let printSettings = PSSVC.newPrintSettings;
>+    printSettings.printSilent     = true;
>+    printSettings.showPrintProgress = false;
>+    printSettings.printBGImages   = true;
>+    printSettings.printBGColors   = true;
>+    printSettings.printToFile     = true;
>+    printSettings.toFileName      = picker.file.path;
>+    printSettings.outputFormat    = Components.interfaces.nsIPrintSettings.kOutputFormatPDF;

Use Ci.

And I think we want to use printSettings.printFrameType = Ci.nsIPrintSettings.kFramesAsIs

We should also get the pagecommand "type" thing working soon so we don't need to add and remove the command.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Address comments.

> We should also get the pagecommand "type" thing working soon so we don't need
> to add and remove the command.

I'll add support for the "type" attribute into bug bug 552526.
Also after playing with it I think this command need to disappear sometimes (or do we want to disabled it? - asking question into bug 552526) because this don't work for XUL pages as example (bug 136185)

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

This patch add some codes to remove the footer/header.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 435238 [details] [diff] [review]
Patch v0.2

works on n900, linux and windows

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/2a256077d2e1

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100329 Namoroka/3.6.3pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.3a4pre) Gecko/20100329 Namoroka/3.7a4pre Fennec/1.1a2pre

folow-up bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=555731
https://bugzilla.mozilla.org/show_bug.cgi?id=555733


We need a new BFT that references these test cases on the site panel. There's some security testcases for that panel in the Security BFT that we'll also need to move over to the new BFT.

Comment 12

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=11742 created to regression test this bug