465358 - Add modules/JSON.jsm to removed-files.in

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

After bug 462774, we need to add modules/JSON.jsm to SM/TB/SB removed-files.in (and check its not in the packages* files which I think is unlikely)

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

Comment 2

[Simon Bünzli]

Comment on attachment 348733 [details] [diff] [review]
The fix

The file's extension is really .jsM (as in JavaScript Module) and not .js.

Comment 3

[Mark Banner (:standard8)]

Attachment: The fix v2

Get it right this time.

Comment 4

[Robert Kaiser]

Comment on attachment 348741 [details] [diff] [review]
The fix v2

Looks good to me, thanks!

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/640b5536ecbf

Comment 6

[Stefan Sitter [:ssitter]]

This busted the Sunbird builds:

[[[
/bin/perl /e/buildbot/comm-central-sunbird-win32/build/calendar/installer/check-remove-files.pl removed-files ../../mozilla/dist/sunbird
make[2]: Leaving directory `/e/buildbot/comm-central-sunbird-win32/build/objdir-tb/calendar/installer'
ERROR: files found that are listed in "removed-files" but exist in "../../mozilla/dist/sunbird": ../../mozilla/dist/sunbird/modules/JSON.jsm
]]]

Maybe they need to be clobbered to pick up the change or JSON.jsm is still build.

Comment 7

[Mark Banner (:standard8)]

I've set it up to clobber the windows build box, not quite sure when that'll occur looking at the current list of builds queued, but hopefully it'll run green sometime in the next few hours.