Mark GUIDs in add-on RSS feeds as isPermaLink=false to point feed readers to add-on details page

VERIFIED FIXED in 4.0.4

Status

addons.mozilla.org Graveyard
Public Pages
--
enhancement
VERIFIED FIXED
10 years ago
2 years ago

People

(Reporter: allblue, Assigned: wenzel)

Tracking

({polish})

unspecified
4.0.4
polish

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3

Some RSS-/Feedreader like Google Reader are not able to treat AMO's links in feed-item correctly.

The attribute Attribute isPermaLink="false" in >guid>-Tag is missing, so the link presented in <guid>-Tag is udes instead of the link in the <link>-tag.


Reproducible: Always

Steps to Reproduce:
1. Subscribe a feed of AMO with Google Reader, e.g. https://addons.mozilla.org/de/firefox/browse/type:1/cat:all/format:rss?sort=newest
2. Click the link in one of the items in the feed.

Actual Results:  
You reach a "versions"-page like that:
https://addons.mozilla.org/de/firefox/addons/versions/9023#version-1.6

Expected Results:  
Expected is the start page of an AddON like that:
https://addons.mozilla.org/de/firefox/addon/9023

Google Reader Team says:

"Reader is behaving correctly here. The feed specifies its GUIDs as
follows:

<guid>https://addons.mozilla.org/de/firefox/addons/versions/
9591#version-0.99</guid>

The RSS 2.0 "spec" has this to say about GUIDs and its relationship to
item permalink (from http://cyber.law.harvard.edu/rss/rss.html#ltguidgtSubelementOfLtitemgt):

"If the guid element has an attribute named "isPermaLink" with a value
of true, the reader may assume that it is a permalink to the item,
that is, a url that can be opened in a Web browser, that points to the
full item described by the <item> element. An example:

<guid isPermaLink="true">http://inessential.com/2002/09/01.php#a2</
guid>

isPermaLink is optional, its default value is true. If its value is
false, the guid may not be assumed to be a url, or a url to anything
in particular."

Since mozilla.org is not specifying isPermaLink="false", Reader, in
following the spec, uses the GUID as the item link. In practice, this
part of the spec is confusing, and Reader has heuristics for handling
things better (e.g. if the GUID claims to be a permalink but is not in
fact a valid URL, Reader will ignore it). Since in this case the GUID
is a valid link, Reader trusts it. It's hard for us to always discern
a publisher's intent in cases like this. We'll look into working
around this from our end, but since mozilla.org is deviating from the
spec, a (friendly) message suggesting to them to add
isPermaLink="false" would also fix things.

Mihai Parparita
Google Reader Engineer"
(Assignee)

Comment 1

10 years ago
That is a good question. When I wrote the code, I was aware of the generic GUID vs. permalink GUID, and the link contained therein *is* a URL and a permalink GUID, and the decision to mark them as a link (or rather, use the default of isPermaLink=true) was deliberate. That consideration makes this bug invalid: Both AMO and Google Reader behave correctly.

However, I understand the request for enhancement. We should probably mark the GUID as isPermaLink=false if we want feed readers to point to the add-on's page instead. At the very least in the case of the "newest add-ons" feed here described this makes sense.

I am going to go ahead and mark the GUIDs as non-permalinks. Targeting for TM 4.0.4.

Thanks for the suggestion.
Assignee: nobody → fwenzel
Severity: major → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
Summary: For all feed-items: Attribute isPermaLink="false" in >guid>-Tag is missing - causes wrong links → Mark GUIDs in add-on RSS feeds as isPermaLink=false to point feed readers to add-on details page
Target Milestone: --- → 4.0.4
(Assignee)

Comment 2

10 years ago
Created attachment 349660 [details] [diff] [review]
adding isPermaLink=false to RSS feed GUID

I added the option to the rss_listitem element and let it default to false, because the <url> field is almost always what we want to link to.

In fact, I still don't see why a news reader would possibly want to link by default to the the GUID of the item displayed (i.e., if only a synopsis of an article is shown in the reader, the GUID points to the *synopsis only*, while the <url> points to the full article), but that's beyond scope here.

So let's force the news readers to do the right thing.
Attachment #349660 - Flags: review?(rdoherty)
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

10 years ago
Comment on attachment 349660 [details] [diff] [review]
adding isPermaLink=false to RSS feed GUID

(Distributing my review requests more fairly.)
Attachment #349660 - Flags: review?(rdoherty) → review?(clouserw)

Updated

10 years ago
Attachment #349660 - Flags: review?(clouserw) → review+
(Assignee)

Comment 4

10 years ago
Fixed in r20474, thanks.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Keywords: push-needed
(Reporter)

Comment 6

10 years ago
Confirming "Verified Fixed"

If it is allowed in a bug entry: Thank you.
(Assignee)

Comment 7

10 years ago
(In reply to comment #6)
> If it is allowed in a bug entry: Thank you.

It sure is. You're very welcome.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.