Closed
Bug 465439
Opened 16 years ago
Closed 16 years ago
show tags in view page
Categories
(Websites :: communitystore.mozilla.org, enhancement)
Websites
communitystore.mozilla.org
Tracking
(Not tracked)
VERIFIED
FIXED
2.0
People
(Reporter: rdoherty, Assigned: rdoherty)
Details
Attachments
(2 files)
|
2.52 KB,
patch
|
abuchanan
:
review+
|
Details | Diff | Splinter Review |
|
464.30 KB,
image/png
|
Details |
No description provided.
| Assignee | ||
Updated•16 years ago
|
Target Milestone: 1.0 → 2.0
| Assignee | ||
Updated•16 years ago
|
Severity: normal → enhancement
| Assignee | ||
Comment 1•16 years ago
|
||
This adds tags to the view page. Not sure on the design/layout yet, planning on getting updates for it once the basic functionality is committed.
Attachment #352643 -
Flags: review?(buchanae)
Updated•16 years ago
|
Attachment #352643 -
Flags: review?(buchanae) → review+
| Assignee | ||
Comment 2•16 years ago
|
||
r20881
Tara, I've added the tags to the detailed view page if you want to check it out. If you have changes, let me know asap.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 3•16 years ago
|
||
Hey Ryan, where can I see the updated page? Is there a new stage site?
| Assignee | ||
Comment 4•16 years ago
|
||
(In reply to comment #3)
> Hey Ryan, where can I see the updated page? Is there a new stage site?
It's the same site it has always been:
http://community-store.stage.mozilla.com/
| Assignee | ||
Comment 5•16 years ago
|
||
And here's a design with tags:
http://community-store.stage.mozilla.com/gallery/view/37
Comment 6•16 years ago
|
||
Hi there. I think it looks great. Only thing I'd change is the font size. A few types smaller to allow for more tags without distorting the layout too much.
| Assignee | ||
Comment 7•16 years ago
|
||
r20904 Has a slightly smaller fontsize. I experimented with an even smaller fontsize, but it began to look out of place.
Comment 8•16 years ago
|
||
Sure. I'm just assuming that people will easily be able to apply many tags to a design, and I wonder what it would look like if we have 10-15 tags for example in that space. I think tags are less important than the rest of the copy there, so smaller is okay as long as it doesn't look too odd.
Comment 9•16 years ago
|
||
Verified FIXED on http://community-store.stage.mozilla.com/gallery/view/37; if we want additional tweaks/features associated with tags, we'll file separate bugs.
Status: RESOLVED → VERIFIED
Two things about this screenshot:
1) proves the functionality works
2) exposes the height-constraints of the layout, which we'll file as a separate bug
(In reply to comment #10)
<snip>
> 2) exposes the height-constraints of the layout, which we'll file as a separate
> bug
Filed bug 469879.
| Assignee | ||
Comment 12•16 years ago
|
||
r20916 has the latest changes according to my discussion with Tara. This includes a smaller fontsize and a darker color for the main paragraph in the detailed view.
Comment 13•16 years ago
|
||
Looks good to me. I'll play around with it to see what longer lines of tags looks like. Otherwise, thumbs up!
You need to log in
before you can comment on or make changes to this bug.
Description
•