465466 - "ASSERTION: Form controls not ordered correctly" with label, XBL

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Form controls not ordered correctly: 'CompareFormControlPosition(aControls[i], aControls[i + 1], aForm) < 0', file /Users/jruderman/central/content/html/content/src/nsHTMLFormElement.cpp, line 1302

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm.  Do anonymous form controls generally register themselves with a non-anonymous form ancestor?  If so, you'll just get this all over.  Try tossing some controls into a binding.  ;)

If they do that, though, it sounds like a bug to me.  Sicking, jst, what do you think?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

IMHO they probably should not.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm.  So nsGenericHTMLElement::FindForm does check for the bindingParent, so that part is ok...

Comment 4

[Boris Zbarsky [:bzbarsky]]

I guess in this case we're mutating the anonymous content after removing the node the binding is attached to from the document, is key.

I hate XBL.

Comment 5

[Jesse Ruderman]

WFM

Comment 6

[Jesse Ruderman]

Crashtest: http://hg.mozilla.org/mozilla-central/rev/e5dd52dd3cb5