Closed Bug 46554 Opened 25 years ago Closed 25 years ago

When all children in block are selected, copy should include the block parent

Categories

(Core :: DOM: Editor, defect, P2)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: akkzilla, Assigned: mozeditor)

References

Details

(Whiteboard: [nsbeta3-][p:2][PDTP2][rtm NEED INFO])

Related to bug 45994: The selection system generally selects only the lowest level inline items, no enclosing block nodes. The clipboard system may need to be smarter than that. If all of the inline children of a block node are selected, then upon copy, we should also select the block node. For example, if you select an entire paragraph and paste it somewhere, the expectation might (*) be that upon pasting it somewhere else, it get pasted with a <p> tag around it. (*) One problem with this is that if you have, say, a list item consisting of one word, there will no way to copy just that word. Perhaps this behavior should be easily switchable, so we can turn it on and then see if it ends up being more annoying than useful.
Status: NEW → ASSIGNED
Keywords: nsbeta2, polish
Target Milestone: --- → M18
Akkana, I'm almost certain you meant to nominate this nsbeta3 rather than nsbeta2, so I changed the keyword. If you really meant to nominate nsbeta2, please change it back and accept my apologies.
Keywords: nsbeta2 → nsbeta3
in particular, you may als owant to grab blocks higher up the chain if all the _block_ children are selected. ie, all the li's in an ol...
Yes, nsbeta3. Thanks for fixing it!
setting to nsbeta3+
Whiteboard: nsbeta3+
altering suimmary. it makes no differnece if children are inline or block. if we have all the children, we want the parent. and if the parent is an only child, we want the grandparent, etc...
Summary: When all inline children are selected, copy should include the block parent → When all children in block are selected, copy should include the block parent
Note that this is not quite as straightforward as it first appears. The selection may not include "non-editable" children, yet still include all the editable children. To the user, this is the same as if all children are included (they cant see a difference). I already have some code somewhere in the editor for doing these kinds of checks. We should appropriate it for use in copy.
setting priority in status whiteboard
Whiteboard: nsbeta3+ → [nsbeta3+][p:1]
moving to m19
Keywords: nsbeta3
Whiteboard: [nsbeta3+][p:1] → [nsbeta3-]
Target Milestone: M18 → M19
Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so the queries don't get all screwed up.
Keywords: nsbeta3
moving out to future
Keywords: helpwanted
Target Milestone: M19 → Future
*** Bug 49728 has been marked as a duplicate of this bug. ***
stealing this bug because i'm such an incredibly nice guy...
Assignee: akkana → jfrancis
Status: ASSIGNED → NEW
evil spirits in this program, COME OUT!
Status: NEW → ASSIGNED
fixed
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
this is a test
another test
Wasn't this backed out? If it was, the bug should be reopened.
had to back out for 50653...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 47014
bringing back in due to dependency
Whiteboard: [nsbeta3-] → [nsbeta3+]
Target Milestone: Future → M18
I hear vidur&jst are removing XIF from our universe. I'm not going to work on this until after that happens since it will rock my world.
See bug 43008: Vidur & JST are tearing out XIF and genreally repiping this whole part of the plumbing. It does not make sense for me to touch this again until after that time. Marking dependant....
Depends on: 43008
moving to m19, setting to -
Keywords: polish
Whiteboard: [nsbeta3+] → [nsbeta3-]
Target Milestone: M18 → M19
fixing this will assist in exporting correct HTML reviewed by Bijal and beppe, setting to nsbeta3+, p2
Keywords: helpwanted → correctness
Priority: P3 → P2
Whiteboard: [nsbeta3-] → [nsbeta3+][p:2]
PDT agrees P2 based on discussion with beppe and ekrock
Whiteboard: [nsbeta3+][p:2] → [nsbeta3+][p:2][PDTP2]
Depends on: 50742
Not holding PR3 for this, so marking nsbeta3-. Nominating for rtm since I understand XIF removal is important to the editor folks.
Keywords: rtm
Whiteboard: [nsbeta3+][p:2][PDTP2] → [nsbeta3-][p:2][PDTP2]
Joe, please include the required information per the rtm checkin rules
Whiteboard: [nsbeta3-][p:2][PDTP2] → [nsbeta3-][p:2][PDTP2][rtm+ NEED INFO]
removing + per pdt sw rules
Whiteboard: [nsbeta3-][p:2][PDTP2][rtm+ NEED INFO] → [nsbeta3-][p:2][PDTP2][rtm NEED INFO]
fixed by noxif landing on trunk. that was sr=kin, r=cast of thousands.
fixed by noxif landing
really marking fixed this time
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
verified in 10/16 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.