46561 - Prevent deletion of Personal/Collected AB. Can now delete,not recreated.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P1)

Description

[laurel]

Using july26 commercial build

If you delete (by accident, of course!) the collected addresses AB, it will not
be recreated even after exit.  You're left with the pref(s) enabled, and no
appropriate messages incoming/outgoing will be collected, no new AB recreated. 
Even if you add a new address book called Collected Addresses, nothing is ever
put there when prefs are enabled. 

1.  Launch to mail window, login to mail account. 
2.  Open Address Book window, check to make sure there is a collected addresses
address book present. Close the address book window.
3.  Edit|Prefs|Mail and Newsgroups|Addressing... enable email address collection
pref and enable to collect from incoming and outgoing messages (this is all
enabled by default).
4.  Read and/or send a message, go to Collected Addresses AB and make sure the
collection does take place. It does.
5.  Delete the Collected Addresses AB (I did this accidentally by trying to
delete the cards within the AB and wiped the actual collected AB out in the
process.)
6.  Close AB window.
7.  Read and/or send a message, check to see if there was any collection.  Note
there is no recreated Collected Addresses AB.
8.  Exit Netscape and relaunch. Check AB window, note there is still no
Collected AB. (At this point I tried toggling prefs off/okaying/enabled them
again. Thought there might be a check for a Collected AB when enabling prefs.
Not so, still no collected AB.)
9.  Add a new address book and name it Collected Addresses. Prefs are still
enabled.
10. Read and/or send a message and check to see if collection took place. Nope.
11. Exit, relaunch and read or send another message, check for collection. Nope.

Result:  If you've wiped out the collected address book, it doesn't get
recreated and you can't get collection to take place again even if you add a new
collected addressbook.

Expected:  I expect it to be recreated, particularly if the prefs are enabled.

Comment 1

[Suresh]

As per spec, both default AB's (Personal AB and Collected AB) _cannot_ be 
deleted.

Comment 2

[laurel]

Oops, I didn't check the spec.  Thanks, Suresh.

Comment 3

[laurel]

I looked, but didn't see any existing bug about preventing deletion of the
Personal and Collected Address Books.  I also checked nbaca's AB window ui bugs,
but didn't find it.

So I'm changing the summary to this bug...

Comment 4

[scottputterman]

nominating for nsbeta3.

Comment 5

[lchiang]

+ per mail triage

Comment 6

[lchiang]

per mail triage, all "mail3" bugs to P1.

Comment 7

[scottputterman]

reassigning to gayatrib

Comment 8

[gayatrib]

I was looking thru this bug and found another interesting observation. I'm not
sure if it is already known.

Go thru steps 1-4 in the biug report. Then instead of deleting the Collected
Addresses AB, delete all the entries in it.

Then you will notice that you can never get to add entries to it again until
youclick on a new/unread message. After you click on a new/unread message,
entries start getting added to it as per the expected nehaviour--i.e. when you
read/send a mail also.

Probably this behaviour should also be fixed..?

Comment 9

[Suresh]

gayatrib, that behaviour is addressed in 47932.

Comment 10

[gayatrib]

I have the fix in hand--if it is ok that the app has to be restarted to see the 
collected/personal address books after they are once deleted.

Actually even if the app is not restarted, the entries get added into 
collectedAddresses, but it does not show up in the address book until the app is 
restarted.

I will try to explore further and see why it does not get shown until the app is 
restarted--but please let me know thoughts on how it is this way.

Comment 11

[gayatrib]

Adding putterman to cc list.

Comment 12

[gayatrib]

ooops--did not add him. Adding him now.

Comment 13

[scottputterman]

I think we should prevent the deletion of the Personal Address Book and the 
Collected Address Book. They can just delete the entries if they want to make 
them smaller.

Comment 14

[gayatrib]

fix checked in.

Comment 15

[esther]

Using build 2000-09-06 on win98, mac and linux this is fixed.  Verified.