465612 - SuggestMgr::SuggestMgr leaks csconv

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Bob Clary [:bc] (inactive)]

start/stop browser

==5146== 2,304 bytes in 3 blocks are definitely lost in loss record 121 of 156
==5146==    at 0x40053C0: malloc (vg_replace_malloc.c:149)
==5146==    by 0x486F8B3: get_current_cs(char const*) (csutil.cpp:5244)
==5146==    by 0x4885465: SuggestMgr::SuggestMgr(char const*, int, AffixMgr*) (suggestmgr.cpp:107)
==5146==    by 0x487B9BC: Hunspell::Hunspell(char const*, char const*, char const*) (hunspell.cpp:105)
==5146==    by 0x485669A: mozHunspell::SetDictionary(unsigned short const*) (mozHunspell.cpp:157)
==5146==    by 0x48393EF: mozSpellChecker::SetCurrentDictionary(nsAString_internal const&) (mozSpellChecker.cpp:373)
==5146==    by 0xBC390ED: nsEditorSpellCheck::SetCurrentDictionary(unsigned short const*) (nsEditorSpellCheck.cpp:455)
==5146==    by 0xBC3ABB9: nsEditorSpellCheck::InitSpellChecker(nsIEditor*, int) (nsEditorSpellCheck.cpp:212)
==5146==    by 0x4845B15: mozInlineSpellChecker::SetEnableRealTimeSpell(int) (mozInlineSpellChecker.cpp:724)
==5146==    by 0x9AE51DB: nsEditor::SyncRealTimeSpell() (nsEditor.cpp:1341)
==5146==    by 0x9AE305F: nsEditor::PostCreate() (nsEditor.cpp:246)
==5146==    by 0x95BD224: nsTextControlFrame::SetInitialChildList(nsIAtom*, nsIFrame*) (nsTextControlFrame.cpp:2812)

SuggestMgr::SuggestMgr inits csconv with a malloc (via get_current_cs) but doesn't free it in the destructor.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Nemeth, as best I can tell, 1.2.9 does not address this. Is that correct?

Comment 2

[Caolan McNamara]

Attachment: proposed fix

Give this a go. There is moz specific code in hunspell to use a dynamic result from get_current_cs which is why it doesn't show up on testing of the standalone version. While I'm at it, there's a mix of malloc/delete as well so also changed to use new[] delete[]

Comment 3

[Caolan McNamara]

Attachment: bah, correct patch

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Any comments, timeless? I'll mark this bug as depending on a future Hunspell 1.2.10 bug upon release.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Fixed by bug 564608