465657 - Only pull reports with comments for topcrasher lists

Status: RESOLVED DUPLICATE of bug 525963

(Socorro :: General, task)

Description

[Michael Morgan [:morgamic]]

When viewing a topcrash signature, by default we should only pull reports with comments up to 50 reports.  Then, we should offer options to pull additional reports via AJAX, eventually adding pagination.

Comment 1

[Michael Morgan [:morgamic]]

Hey - do you guys care if we pull only reports with comments?  It would reduce the strain on the server for topcrash listings until we have more time to paginate.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Personally I'm not as glad about this. This change will force us to have extra clicks to get our needed reports. Please keep in mind that I think less than 1% of all the users are supplying a comment to their crash report. That's odd, because we aren't able to figure out some STR to reproduce the crash. If we now hide all reports without a comment it will definitely limit our work on Soccorro.

A good first option would be to force the user in entering an useful comment. He could still decline but should a notification that a comment would be very helpful. With that I would agree to this proposal.

Comment 3

[(not currently active) Ted Mielczarek]

We are not going to force users to enter comments. Ever. I believe morgamic's point is that for any given signature, there are generally some reports with comments, so instead of showing you 50+ reports all with the same signature, you'd just see reports with comments first. Presumably this could be setup such that if there are no reports with comments, we just show the first 10 reports or whatever.

Comment 4

[Tony Chung [:tchung]]

The most important thing we need here, is the top 10 unique crash reports, and the frequency of these reports.  As long as i can still get all this data somehow, this is fine by me.

Comment 5

[Samuel Sidler (old account; do not CC)]

Tony, that's completely unrelated to this bug. And, while I agree that data is important, it's fairly useless without more data.

In any case, to answer comment 1... I'm fine with pulling reports with comments by default, but we need a way to see more than that. So I'm only okay with that *if* you allow me to load more reports as well. Fixing this bug only isn't enough and would be a regression for my usage (I need to be able to load a bunch of reports to compare stacks/modules/etc).

Comment 6

[chris hofmann]

agree with sam.  this can be one report option and the default but we need to view reports without comments still.   "startup" crashes rarely have comments since the user has no idea what to say, but we still can make progress looking at the stacks, and the time since startup, and the module list.

since we are also not doing the kind of unique stack signature assignment in all cases we might miss out on diagnosing one kind of crash that has no comments when we see another kind of crash that has several comments.

Maybe we can bring up the report you are suggesting, have a look, and compare it to see if we can use it for the bulk of analysis.  Then swap it in as the defualt if it looks like it will be useful in getting the bulk of the analysis work done.

Comment 7

[chris hofmann]

It seems rare that any top signature has more than 5 or 10 comments.  Thats because we get so few comments coming in per day.  On a typical day here are the signatures that get the most comments, and counts.

number-of-comments-per-day   stack signature

  21 @0x0
  19 NPSWF32.dll@0x77bd0
  19 NPFFAddOn.dll@0x11867
  14 nsBaseWidget::Destroy()
  12 GoogleDesktopMozilla.dll@0x5512
  12 CFReadStreamGetStatus
  11 js_Interpret
  11 arena_dalloc_small | arena_dalloc | free | XPT_DestroyArena
  11 _PR_MD_SEND
  11 RtlpWaitForCriticalSection
  10 nsIFrame::GetAncestorWithView()
  10 UserCallWinProcCheckWow
   9 arena_run_reg_alloc
   8 RaiseException | _CxxThrowException
   8 KiFastSystemCallRet
   7 nsGlobalWindow::cycleCollection::UnmarkPurple(nsISupports*)
   7 nsEventListenerManager::Release()
   7 nsCycleCollectingAutoRefCnt::decr(nsISupports*)
   7 arena_chunk_init
   6 nsStyleSet::FileRules(int (*)(nsIStyleRuleProcessor*, void*), RuleProcessorData*)
   6 nsFrame::BoxReflow(nsBoxLayoutState&, nsPresContext*, nsHTMLReflowMetrics&, nsIRenderingContext*, int, int, int, int, int)
   6 free | js3250.dll@0x84d85
   6 _woutput_l
   6 ___TERMINATING_DUE_TO_UNCAUGHT_EXCEPTION___
   6 NPSWF32.dll@0xbc897
   6 GoogleDesktopMozilla.dll@0x5500
   6 Flash Player@0x92160

Could we just leave things the way they are?  what would we be trying to optimize with the change suggested?

Comment 8

[Michael Morgan [:morgamic]]

Bug 525963 covers adding the ability to retrieve/browse all comments for a crash signature.  Believe this should get us what we want.  Trending is covered in bug 411397.