Closed Bug 465717 Opened 11 years ago Closed 11 years ago

WCAP calendars are not available in lightning/sunbird build 20081118

Categories

(Calendar :: Provider: WCAP, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: andreas.treumann, Assigned: dbo)

References

Details

(Keywords: regression)

Attachments

(1 file)

STEPS TO REPRODUCE:
===================

- use lightning/sunbird 20081117 and subscribe to a wcap calendar
- update this profile with the 20081118 build
- restart the application

RESULT:
=======

- the wcap calendar is marked 'not available' in the calendar list
- error at startup in the error console:

Warning: There has been an error reading data for calendar: Andreas Treumann.  However, this error is believed to be minor, so the program will attempt to continue. Error code: 0x80004005. Description: NS_ERROR_FAILURE

Warning: There has been an error reading data for calendar: Andreas Treumann.  However, this error is believed to be minor, so the program will attempt to continue. Error code: READ_FAILED. Description: READ_FAILED
EXPECTED RESULT:
================

- the wcap calendar should be available

REPRODUCIBLE:
=============

- always

Regression possible caused by checkin bug 436047.
Flags: blocking-calendar1.0?
Flags: blocking-calendar1.0? → blocking-calendar1.0+
Attached patch fix - v1Splinter Review
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #349178 - Flags: review?(philipp)
Blocks: 465911
Comment on attachment 349178 [details] [diff] [review]
fix - v1

>-            return cal.ical.subcompentIterator(aComponent, compType);
Oops, sorry about that :-}

>     for (let subComp in cal.ical.calendarComponentIterator(icalRootComp, componentType)) {
>-        if (++count > maxResults) {
>-            break;
>-        }
No checking for maxResults anymore?

r=philipp
Attachment #349178 - Flags: review?(philipp) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a7ac7311d9e0>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
(In reply to comment #2)
> No checking for maxResults anymore?
Sure, maxResults is passed to the server as well as checked when expanding occurrences.
Checked in lightning and sunbird buils 20081124 -> VERIFIED.
Status: RESOLVED → VERIFIED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.