Perl errors in TestOutSinks.pl

VERIFIED FIXED in M18

Status

()

Core
HTML: Parser
P3
normal
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: Peter 'Rufus' Nelson, Assigned: Akkana Peck)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

18 years ago
Well, it's kinda obvious that whoever wrote this was thinking C instead of Perl.
 Here are the errors:

Line 46:
print "xxxxxxxx Status = " + $status + "\n";
should be:
print "xxxxxxxx Status = " . $status . "\n";

also Line 60:
$status = system("# TestOutput -i text/html -o text/plain -f 32 -c
OutTestData/plainwrap.out OutTestData/plain.html");
should be:
# $status = system("TestOutput -i text/html -o text/plain -f 32 -c
OutTestData/plainwrap.out OutTestData/plain.html");

Comment 1

18 years ago
Akkana is this yours?
Assignee: rickg → akkana
(Assignee)

Comment 2

18 years ago
Yes, this is mine.  I was thinking JS -- that would do something even more
unexpected in C. :-)  Thanks for noticing and offering the fix!
Status: NEW → ASSIGNED

Updated

18 years ago
Keywords: correctness
Target Milestone: --- → M19

Comment 3

18 years ago
putting to m19, this is a testscript fix
(Assignee)

Comment 4

18 years ago
Fixed -- thanks again!
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

17 years ago
Sorry for the spam!  But apparently all these closed bugs need to have their
target milestones changed since M19 and M20 are going away.  Since they're
allready closed, I'm choosing M18.
Target Milestone: M19 → M18

Comment 6

17 years ago
updated qa contact.
QA Contact: janc → bsharma

Comment 7

17 years ago
Marking verified as per above developer comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.