ns/client.mak mozilla pull is broken

VERIFIED FIXED in mozilla1.0

Status

SeaMonkey
Build Config
P3
normal
VERIFIED FIXED
18 years ago
13 years ago

People

(Reporter: Jon Granrose, Assigned: kysmith0 (gone))

Tracking

Trunk
mozilla1.0
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fix in hand, need r=)

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
It's been a fun day.  I may be missing something but...

Just updated the ns/client.mak file with the SeaMonkey_M17_BRANCH tag.  Closer
examination shows that if you checkout a ns/client.mak and do a nmake /f
client.mak pull_all, it pulls with the right tag, but only pulls SeaMonkeyAll
for mozilla.  This works for branches since nspr, psm, ldap etc are already
tagged as M17.  I don't see how this could work on the trunk.

ns/client.mak should not be pulling anything directly for mozilla, it should be
pulling mozilla/client.mak and doing a pull_all using that makefile.
(Reporter)

Comment 1

17 years ago
reassigning to kysmith as this is a good intro to the win32 makefiles, cc leaf
for r=.  setting moz1.0.

kyle - we need to change the pull_all target in ns/client.mak to check out
mozilla/client.mak and run a pull_all with it rather than pulling the mozilla
tree directly the way ns/client.mak currently does it.
Assignee: leaf → kysmith
Target Milestone: --- → mozilla1.0
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

17 years ago
Created attachment 31518 [details]
diffs in this attachment
(Reporter)

Comment 3

17 years ago
cool.  looks good to me, but let's get the r= from leaf since win32 is his baby.
Whiteboard: fix in hand, need r=

Comment 4

17 years ago
r=leaf, groovy, baby!
(Assignee)

Comment 5

17 years ago
Fix checked in...resolving fixed. 
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

17 years ago
verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.