Closed
Bug 465805
Opened 16 years ago
Closed 16 years ago
Crash in shredder during body search
Categories
(MailNews Core :: Search, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: rkent, Assigned: rkent)
Details
Attachments
(2 files, 2 obsolete files)
|
800 bytes,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
|
6.97 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
Doing a large body search, TB/Shredder reproducibly crashes in nsMsgBodyHandler.cpp. In the debugger, there is an infinite recursion calling ApplyTransformations with a zero length buffer.
|
Assignee | |
Comment 1•16 years ago
|
||
This patch successfully stops the crash on my system.
Attachment #349027 -
Flags: superreview?(bienvenu)
Attachment #349027 -
Flags: review?(bienvenu)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 349027 [details] [diff] [review] [checked in] Detect and warn if buffer is empty makes sense, thx, Kent - can we add a test case for this?
Attachment #349027 -
Flags: superreview?(bienvenu)
Attachment #349027 -
Flags: superreview+
Attachment #349027 -
Flags: review?(bienvenu)
Attachment #349027 -
Flags: review+
|
|
||
Comment 3•16 years ago
|
||
fix checked in, thx, Kent - changeset: 1155:aaf9a85fde16
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
|
|
Assignee | |
Comment 4•16 years ago
|
||
Same .cpp, added the test case. Although I can display that email OK, search does not find terms that I can see when I display it. That's probably a separate bug (or not worth it?)
Attachment #349027 -
Attachment is obsolete: true
Attachment #349056 -
Flags: superreview?(bienvenu)
Attachment #349056 -
Flags: review?(bienvenu)
|
|
Assignee | |
Comment 5•16 years ago
|
||
Oops, I noticed you checked it in. Let me redo the patch without the .cpp part.
|
|
Assignee | |
Updated•16 years ago
|
Attachment #349027 -
Attachment is obsolete: false
|
|
Assignee | |
Comment 6•16 years ago
|
||
I don't think this needs sr - though that's a trivial point here.
Attachment #349056 -
Attachment is obsolete: true
Attachment #349058 -
Flags: review?(bienvenu)
Attachment #349056 -
Flags: superreview?(bienvenu)
Attachment #349056 -
Flags: review?(bienvenu)
|
|
Assignee | |
Comment 7•16 years ago
|
||
As requested by bienvenu.
Attachment #349058 -
Attachment is obsolete: true
Attachment #349063 -
Flags: review?(bienvenu)
Attachment #349058 -
Flags: review?(bienvenu)
|
|
||
Comment 8•16 years ago
|
||
Comment on attachment 349063 [details] [diff] [review] [checked in] Test case with fewer and obscured headers thx, Kent.
Attachment #349063 -
Flags: review?(bienvenu) → review+
|
||
Comment 9•16 years ago
|
||
Comment on attachment 349027 [details] [diff] [review] [checked in] Detect and warn if buffer is empty http://hg.mozilla.org/comm-central/rev/aaf9a85fde16
Attachment #349027 -
Attachment description: Detect and warn if buffer is empty → [checked in] Detect and warn if buffer is empty
|
|
||
Comment 10•16 years ago
|
||
Comment on attachment 349063 [details] [diff] [review] [checked in] Test case with fewer and obscured headers I've just pushed the test case: http://hg.mozilla.org/comm-central/rev/6061ec9cd615
Attachment #349063 -
Attachment description: Test case with fewer and obscured headers → [checked in] Test case with fewer and obscured headers
|
|
||
Updated•16 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•