465863 - [silme] Improve exception handling in io.file.py

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Adrian Kalla [:adriank]]

Attachment: patch v1

We have some problems with the exception handling in silme.io.file. The submitted patch fixes:

-don't fall silently on every possible exception
-fix raising UnicodeDecodeError (it's causing a TypeError at the moment)
-add TODOs for exceptions that should be logged in the future (after the silme.core.logging lands)

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 349096 [details] [diff] [review]
patch v1

>diff --git a/lib/silme/io/file.py b/lib/silme/io/file.py
>--- a/lib/silme/io/file.py
>+++ b/lib/silme/io/file.py

>   @classmethod
>   def getSourceWithEncoding(cls, path, encoding):
>     try:
>       f = codecs.open(path, 'rU', encoding=encoding)
>       text = f.read()
>     except UnicodeDecodeError, e:
>-      raise UnicodeDecodeError(path + ': ' + str(e))
>+      raise UnicodeDecodeError, e
>     except IOError, e:
>       raise IOError(path + ': ' + str(e))

why do you remove path here?

except of this it looks good.

Comment 2

[Adrian Kalla [:adriank]]

Gandalf: because you cannot raise a UnicodeDecodeError with only one argument. If you don't do that with exactly 5 arguments, it'll raise a TypeError.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

commited