[silme] enhancements to scripts/map_structure.py

RESOLVED FIXED

Status

Mozilla Localizations
Infrastructure
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: adriank, Assigned: adriank)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Assignee)

Description

10 years ago
Created attachment 349101 [details] [diff] [review]
Pythonization

About 6 weeks ago I made 5 patches for map_structure.py:

1) Pythonization
2) case where we have 2 or more files with the same name in dir1 but only one in dir2
3) show warnings if files from dir1 weren't mapped
4) don't crash if the input wasn't a number or the number was greater than the number of options (a crash after the 99 question is frustrating)
5) show more information: show always path+file_name (requires patch4 applied first)
(Assignee)

Comment 1

10 years ago
Created attachment 349102 [details] [diff] [review]
patch2: case where we have 2 or more files with the same name in dir1 but only one in dir2
(Assignee)

Comment 2

10 years ago
Created attachment 349103 [details] [diff] [review]
patch3: show warnings if files from dir1 weren't mapped
(Assignee)

Comment 3

10 years ago
Created attachment 349104 [details] [diff] [review]
patch4: don't crash if the input wasn't a number or the number was greater than the number of options
(Assignee)

Comment 4

10 years ago
Created attachment 349105 [details] [diff] [review]
patch5: show always path+file_name (requires patch4 applied first)
commited, fixed, thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.