465909 - Clicking Edit for the status of a bug doesn't display Commit button

Status: VERIFIED DUPLICATE of bug 465746

(bugzilla.mozilla.org :: General, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Since ever the latest upgrade lands on bmo it's more annoying to handle the bug status. If you want to change something and you click on 'Edit' right behind the current status on the top, the page is scrolled down and shows the drop down boxes directly near the window border. That's bad because of at least two things:

* You can accidentally click outside the window if you want to do a quick action.

* If you want to change the status you have to additionally scroll down to see the commit button.

Both things are odd and not necessary. Please fix it. It will make us the live more easier. Thanks!

Comment 1

[Frédéric Buclin]

bmo will catch this when it's upgraded again, I guess in a few days.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sorry Frederic, I don't see how bug 464732 should solve this issue. I don't talk about the Status label. Is there a preview already working somewhere which I could test?

Comment 3

[Frédéric Buclin]

https://landfill.bugzilla.org/bugzilla-tip has current code. The Commit button is now on the right of the status field, so you no longer need to scroll to see it. About accidentally clicking outside the window, I don't see how that's worse than having the field at the top of the window and accidentally clicking the "close tab" button. ;)

So I marked your bug as a dupe based on your 2nd comment only.

Comment 4

[Dave Miller [:justdave]]

https://bugzilla-stage-tip.mozilla.org/ is now running this also.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With that change we should at least show up "Mark as Duplicate" without the need of scrolling down. For now its still not a good behavior. Is this already covered somewhere else?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is not fixed with the latest push. The commit button is still not visible when clicking on Edit.

Comment 7

[Frédéric Buclin]

(In reply to comment #6)
> This is not fixed with the latest push. The commit button is still not visible
> when clicking on Edit.

Which push? There has been none since you reported this bug.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sorry, I mixed it up with the tracking bug of the 08 regression bug.

Frederic, do we have a bug which covers the "Mark as Duplicate" link show up when clicking on Edit? If not, can we probably morph this bug to also handle this case? See also comment 5.

Comment 9

[Frédéric Buclin]

Bug 464732 not only moved the Commit button on the same line as the status field, but it also changed the behavior of the (edit) link. Rather than focusing the status field at the very bottom of the page as it does currently on bmo (leaving the Mark as Duplicate link out of view), it now scrolls down to the additional comment box + focuses the status field, meaning that the Mark as Duplicate link is also near the center of the window.

What justdave said in comment 4 is inaccurate, though. bugzilla-stage doesn't have the fix yet, so you should test using the URL I gave in comment 3.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, that looks good so far. Resolving as dupe again. Thanks Frederic.

Comment 11

[Dave Miller [:justdave]]

(In reply to comment #9)
> What justdave said in comment 4 is inaccurate, though. bugzilla-stage doesn't
> have the fix yet, so you should test using the URL I gave in comment 3.

Actually that wasn't innacurate.  And it's live in production now.  And it's still broken with regard to the mark as duplicate link.  So this didn't get backported correctly to the bmo branch (or an early version of it and not the final version did?)

Comment 12

[Dave Miller [:justdave]]

LpSolit: I don't see anything in the patch on bug 464732 that would change the behavior the way you describe in comment 9.  That patch got backported accurately as far as I can tell.

Comment 13

[Dave Miller [:justdave]]

The magic code on trunk appears to be this:

          (<a href="#add_comment" 
              onclick="window.setTimeout(function() { document.getElementById('bug_status').focus(); }, 10)">edit</a>)

That code is not included in the mentioned patch.  Must have been some other bug did that.

Comment 14

[Dave Miller [:justdave]]

Found it.  Bug 465746, which indeed hadn't been committed on the 3.2 branch yet when we pulled what just got pushed to production, and was indeed a separate issue upstream from this.  I'll try to push it out sometime today.

Comment 15

[Dave Miller [:justdave]]

just fyi the duplicate fix has been deployed to production now.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So what was the reason to let the commit button float on the right side? You have to move the mouse pointer far to the right to commit an action. Why it's not beyond the status label anymore where it is faster accessible? Further the position of the commit button changes now, depending on the window and document width as what you can see on bug 465746. Personally I really don't like that behavior.

Shouldn't it be at least a dupe of bug 465746 when the patch is on that bug? Just wondering.

Comment 17

[Max Kanat-Alexander]

(In reply to comment #16)
You're talking about bug 466912.