46606 - sane plugin defines CID in .idl file

Status: RESOLVED INVALID

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Michael Ang]

NS_SANE_PLUGIN_CONTROL_CID should be defined in nsSanePlugin.h as opposed to
nsSanePluginInstance.idl, since it is specific to the implementation.

Some additional, non-authoritative, suggestions on style:
- name the interface nsISanePlugin instead of nsISanePluginInstance (it doesn't
make sense to have an "instance" of an interface)
- use the filename nsISanePlugin.idl instead of nsSanePluginInstance.idl
- define the progid in nsSanePlugin.h to help with searching/browsing

Very very cool, BTW.  Maybe I should spend less time on pedantry and implement
something equally neat. ;)

Comment 1

[Michael Ang]

Sean Echevarria <[e-mail]> pointed out that nsISanePluginInstance
is the correct name for the interface according to convention.  Ugh.

So the filename should be nsISanePluginInstance.idl instead of
nsSanePluginInstance.idl, but at this point I should probably just shut up.

Comment 2

[ekrock's old account (dead)]

Not a Netscape 6 RTM blocker. FUTURE. This bug has been marked Future because
the Netscape engineer it is assigned to is overburdened.

Comment 3

[Matthias Versen [:Matti]]

[e-mail]: Are you working on this bug ?

Comment 4

[Matthias Versen [:Matti]]

-> default owner

Comment 5

[rubydoo123]

I talked with Peter about this one this morning, this is an old example using
deprecated functions. This should be pulled fromt he tree.

Assigning to Anthony

Comment 6

[anthonyd]

remove what though actually? The header file, the idl file, the whole
mozilla/modules/plugin/samples/SanePLugin directory in the tree?

I can do this no problem, but I need to know exactly what should be removed.

Comment 7

[Peter Lubczynski]

that sample uses the XPCOM API but I just noticed it uses nsGetFactory
(http://lxr.mozilla.org/mozilla/source/modules/plugin/samples/SanePlugin/nsSanePluginFactory.cpp#224)
so it probably still works just like Java and Real.  It looks like a nice sample
and maybe could be converted to NPAPI+nsIClassInfo? 

Comment 8

[av (gone)]

If we decide to remove it, the whole folder should be removed. But as Peter said
this is really cool plugin, it would be a pity just to discard it. I think we
should at least try to clean it up (see if it is up to our coding/naming style,
factor out some code to separate files if needed, make it NPAPI style plugin)
and then maybe do the same for other platforms and add it to the SDK. I don't
know though, are SANE libraries available on other platforms? This is for the
future anyway.

We need to take a look at the Samples folder. I think Simple can be removed (and
must be, because for some reason people tend to look at it first). Other project
that look suspicious to me are Backward and Testevents. Are they of any usefulness?

Comment 9

[anthonyd]

well, lets list the sample plugins in this bug that should be removed.

so far we have the simple plugin should be removed.

Comment 10

[anthonyd]

so do you just want me to remove the simple plugin in the samples folder?

Comment 11

[av (gone)]

I would do that. Nobody seems to object, so go for it. You will probably need to
ask leaf for a special favour to remove the empty dir because normally cvs will
not do it for you.

Comment 12

[Peter Lubczynski]

--->peterl

Comment 13

[Josh Aas]

This bug is about something that no longer exists.