Closed
Bug 466083
Opened 16 years ago
Closed 16 years ago
gloda initial indexing sweep should be indexer-controlled and disabled for unit tests
Categories
(MailNews Core :: Database, defect)
MailNews Core
Database
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: asuth, Assigned: asuth)
References
Details
Attachments
(1 file)
7.95 KB,
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
The initial indexing sweep is currently triggered using a timer in public.js. This was a sketchy place to do it. Additionally, having an indexing sweep happen in unit testing is wildly unhelpful. The triggering should be completely internalized in indexer.js and unit tests should be able to disable it.
Attachment #349331 -
Flags: review?(dmose)
Assignee | ||
Updated•16 years ago
|
Whiteboard: [has patch][needs review dmose]
Comment 1•16 years ago
|
||
Comment on attachment 349331 [details] [diff] [review] v1 move initial sweep initiation, no sweep for unit tests Looks good; r=dmose.
Attachment #349331 -
Flags: review?(dmose) → review+
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [has patch][needs review dmose] → [has reviewed patch][needs checkin]
Comment 2•16 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/e1f22613e1f9
Keywords: checkin-needed
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has reviewed patch][needs checkin]
You need to log in
before you can comment on or make changes to this bug.
Description
•