Closed Bug 466108 Opened 13 years ago Closed 13 years ago

remove extra argument from GetWidthInfo in BasicTableLayoutStrategy

Categories

(Core :: Layout: Tables, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
I've had this trivial patch in my tree since January; I wrote it while working on bug 413361 and never attached it anywhere, as far as I can tell.

It removes an extraneous |const nsStylePosition*| argument from GetWidthInfo and just gets that from the frame, which is also an argument (although I think added later, since the frame used to be passed only for cells and not for columns).

Also fixes an incorrect comment (from that change that allowed this cleanup) and a spelling mistake in another comment.
Attachment #349365 - Flags: superreview?(roc)
Attachment #349365 - Flags: review?(dholbert)
Comment on attachment 349365 [details] [diff] [review]
patch

Looks pretty trivial/straightforward to me. r=dholbert
Attachment #349365 - Flags: review?(dholbert) → review+
Attachment #349365 - Flags: superreview?(roc) → superreview+
Fixed: http://hg.mozilla.org/mozilla-central/rev/c0bf3fd88ffd
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.