46613 - Complete Classic Skin work

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P1)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

The classic skin is not yet complete. It is in a running state, and most things 
work but it is not in a shipping state. Lots of polish work needs to be done to 
improve its aesthetics and usability. 

I am currently sitting on a bunch of changes that improve the Navigator 
toolbar/urlbar area dramatically, and would like to get them in before they 
bitrot ;)

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

nominating for nsbeta3, adding polish keyword. 

Comment 2

[Blake Ross]

Ben: do you want polish issues to be posted here, or filed as separate bugs?

Comment 3

[Blake Ross]

I'm going to make this bug dependent on some win32 classic polish fixes.  This
should be nsbeta3+'ed to complete the work that ben has in mind, but the
designation should not necessarily extend to this bug's dependencies.

Comment 4

[german]

cc'ing relevant folks

Comment 5

[johng]

nav triage team:
nsbeta3+, work with UI folks to reduce the scope of this work if possible.

Comment 6

[Stephen Walker]

adding bug 48443 (under windows in classic skin, url entry background color 
wrong when using different system colors) as a dependency

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

desirable for PR3. 

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

hm.. did I fix this? must have been an accident. 

Comment 9

[leger]

Adding classic keyword

Comment 10

[leger]

Putting on [PDTP5], please nominate individual classic bugs for nsbeta3.  
Neither of the depends bugs is nominated yet.  Yep, lots to do, but please break 
down the tasks per bug.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

PDTP5 for Netscape, P1 for Mozilla. 

It's still hard to quantify all the individual tasks as there are many polish 
glitches on Windows and Mac I'll do my best to produce a list and reflect them 
into bugs asap. 

Comment 12

[Blake Ross]

*** Bug 46519 has been marked as a duplicate of this bug. ***

Comment 13

[lchiang]

per PDT team:  this is a P5 for Netscape and not needed for Netscape's beta3 so
marking nsbeta3-.  Will not touch the P1 priority of this bug.

Please file separate bugs for problems with the classic skin and feature/polish.
Phil has currently gone through the bugs with keyword "classic" and has
nominated the bugs that Netscape would like to have fixed with nsbeta3 keyword.

Thanks.

Comment 14

[Jason Eager]

How close are we to completing the classic skin work?

Comment 15

[Blake Ross]

*** This bug has been marked as a duplicate of 46519 ***

Comment 16

[Matthew T (active 1999-2002)]

Verified dup.

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

reopening now the original bug has been closed. 

Comment 18

[Blake Ross]

Now that it's a new release cycle and there's no longer a need for a blanket + 
bug to check in under, can we close this up now?  The Classic skin is pretty 
far from "completion"

Comment 19

[Simon Lucy]

A major cleanup for the Classic skin would be to change the default font for 
widgets to be message-box.  The current font in global.css is dialog, font-
family san-serif, this is a bad assumption.  

Comment 20

[Simon Lucy]

Attachment: A set of diffs for further cleaning up the windows classic theme

Comment 21

[Simon Lucy]

I've attached a set of diffs that attend to several inconsistencies, slider
background, sidebar font sizes and colours of tabs.  A major change is in
global.css to change the default widget font to message-box as dialog comes out
very small.

Comment 22

[Simon Lucy]

Attachment: Corrected diffs file, removing testing irrelevancies

Comment 23

[Simon Lucy]

Ignore the first attachment of diffs, that has some testing junk in it.

Comment 24

[Joe Hewitt (gone)]

Taking from Ben

Comment 25

[Joe Hewitt (gone)]

Marking FIXED because this bug is too general, and I think it served it's
original purpose back in the pre-Netscape 6 days.  Specific classic bugs should
be filed separately. 

Comment 26

[Blake Ross]

vrfy fixed

Simon, please file new bugs for those issues and attach your patches.

Comment 27

[Simon Lucy]

That would be about 11 new bugs with me cutting up the diffs file for each one, 
that seems a lot of work for no benefit, since the man has taken the patches 
and probably tweaked them anyway.

I posted the patch to this bug it was open at the time, why not treat it 
properly?  Just because its vague and open ended?  I think that was probably 
why it was opened in the first place.