46616 - repeatedly selecting search category adds "hidden search engines"

Status: VERIFIED FIXED

(Core Graveyard :: RDF, defect, P3)

Description

[Chris Waterson]

To reproduce:

1. Open the search panel
2. Choose "Search -> My Sidebar Search Panel -> Advanced" from the main menu.
3. In the search panel, select the "Within" drop down several times.

After the 3rd or 4th time, you'll see a scrollbar appear in the search panel.
Scrolling will reveal a whole bunch of duplicate entries in the list.

Comment 1

[Chris Waterson]

I'll call it "polish", but I'm pretty sure that this is indicative of a evil
problem in the XUL template builder...

Comment 2

[Robert John Churchill]

cc'ing johng as he was asking about this problem

Comment 3

[ekrock's old account (dead)]

Not sure who approved this as nsbeta3+, but the correct marking is [nsbeta3+]
(note brackets). Corrected that.

Comment 4

[Robert John Churchill]

*** Bug 47273 has been marked as a duplicate of this bug. ***

Comment 5

[Claudius Gayle]

each time you click you get another complete copy of the search engines ad nauseaum. Search bug (on the surface) taking QA

Comment 6

[Chris Waterson]

This is happening because somehow I've managed to botch 
RemoveGeneratedContent() when it comes to trees that have a <treechildren> 
element specified "outside" of the template.

Comment 7

[Chris Waterson]

Attachment: the "elegant" fix

Comment 8

[Chris Waterson]

Here's how I wish I could fix it. This lets the rule network figure out which 
rules "unmatch" (or "retract") when you yank an element out of the content 
model. Unfortunately, because of our wonderous content model APIs, it ends up 
going O(n^2) or worse because it essentially ends up removing content randomly. 
This changes the time it takes to switch *away* from a 10,000 message mailnews 
folder from something like 2sec up to 6sec.

The alternative is to special-case <treewidget>, which is ugly, but probably 
faster.

Comment 9

[Chris Waterson]

Oh, wait. I forgot that there's still something wrong with this fix. Opening 
and closing folders ends up doubling the sub-content each time.

Comment 10

[Robert John Churchill]

*** Bug 47327 has been marked as a duplicate of this bug. ***

Comment 11

[Robert John Churchill]

*** Bug 47327 has been marked as a duplicate of this bug. ***

Comment 12

[Chris Waterson]

Attachment: better fix; use a queue to probe for generated content

Comment 13

[Robert John Churchill]

Looks good;  r=rjc

Comment 14

[Chris Waterson]

fix checked in

Comment 15

[Tom Everingham]

verified:
Win NT 2000090808
Linux rh6 2000090708
Mac OS8.6 2000090704