Closed Bug 466212 Opened 16 years ago Closed 15 years ago

gloda falls back to hard-coded string "Me" to create user identity, should be l10n'ed or dropped if not needed

Categories

(MailNews Core :: Database, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: asuth, Assigned: asuth)

References

Details

(Whiteboard: [no l10n impact][target slushy])

Attachments

(1 file)

Gloda._initMyIdentities creates a contact for the profile user; for each account, it creates an identity associated with that contact.  It uses the first fullName it finds associated with one of those accounts, or failing that, the hard-coded string "Me".

Ideally, I think we want to avoid using "Me" or any translation of "Me", so the right course of action is probably to:
0) Drop the fallback to "Me" entirely.
1) When no accounts exist, don't create the myContact contact.  Instead, defer the creation until such time as an account has been created.
2) If no fullName or other legitimate alternative is available, name the contact after the account's e-mail or other thing.
3) Perhaps listen to account changes in case the user changes their name.  That way we can replace the e-mail address fallback with their name.

Our super ideal desire would be to have an explicit mapping to an address book contact for the user.
Priority: -- → P3
Blocks: 464354
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 3.0b2
Flags: blocking-thunderbird3?
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Whiteboard: [has l10n impact]
No l10n impact.  The "Me" is actually in code where localizers can't find it, and we're going to get rid of it rather than canonicalize it.
Whiteboard: [has l10n impact] → [no l10n impact]
Whiteboard: [no l10n impact] → [no l10n impact][target slushy]
Bug 475502 handles all the listening cases, leaving us to mainly never ever ever use "Me".
Attachment #361957 - Flags: superreview?(dmose)
Attachment #361957 - Flags: review?(dmose)
Comment on attachment 361957 [details] [diff] [review]
v1 be better about trying to get a name, and fallback to an email address if we must

r+sr=dmose
Attachment #361957 - Flags: superreview?(dmose)
Attachment #361957 - Flags: superreview+
Attachment #361957 - Flags: review?(dmose)
Attachment #361957 - Flags: review+
pushed http://hg.mozilla.org/comm-central/rev/aa2548c89200
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.