466254 - Workers: Implement close() and onclose handlers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Part of the spec we didn't quite hit. Highly desired by Google and others for killing server locks and allowing cleanup.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Not totally complete but very functional. Only thing missing is delaying window/app teardown while the close handler is running.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1.1

Added a few code comments that jst brought up in review, and made setTimeout/setInterval return a valid serial in close handlers, even though they still do nothing.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Leak fix

I landed this on Sunday to fix a leak seen on tinderbox... The test harness sets the script timeout to 0 which caused the close runnable to be rejected, thus leaking any features that were active.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Pushed changeset 388c17a510e8 to mozilla-central.

Comment 5

[Serge Gautherie (:sgautherie)]

Is this going to land on 1.9.1 too, or is it trunk only ?

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Beta 2 was the cutoff for worker features.

Comment 7

[Eric Shepherd [:sheppy]]

Added information to:

https://developer.mozilla.org/En/Using_web_workers#Terminating_a_worker

https://developer.mozilla.org/en/XPCOM_Interface_Reference/NsIWorkerScope

Please comment and reset to dev-doc-needed if there are any issues with these edits.