Closed Bug 466342 Opened 13 years ago Closed 13 years ago

editContactOverlay over-CSSes

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch FixSplinter Review
The original reviewer must have been asleep at the wheel - editContactOverlay.xul includes both chrome://messenger/skin/ and chrome://messenger/content/messenger.css as stylesheets, despite:

* messenger/skin/messenger.css includes messenger/content/messenger.css, so you never need content if you have skin

* the stylesheets for both places where editContactOverlay.xul is overlaid already include messenger/skin/messenger.css (and thus messenger/content/messenger.css)

As a result, if you use DOMi to look at the messagereader panel, and look at CSS Style Rules for something like expandedfromBox, you'll see that the rule from messenger/content/messenger.css is being applied five times, two of the extras being from editContactOverlay.xul.
Attachment #349617 - Flags: review?(bugzilla)
Attachment #349617 - Flags: review?(bugzilla) → review+
https://bugzilla.mozilla.org/show_bug.cgi?id=466342
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.