Closed Bug 466397 Opened 11 years ago Closed 11 years ago

tweak entity names so that all locales pick up the removal of ellipsis from reply & forward

Categories

(Thunderbird :: Mail Window Front End, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: davida, Assigned: philor)

Details

(Whiteboard: [has l10n impact])

Attachments

(1 file)

this was done too late for b1, so doing it in a separate bug.  The substantive change is the removal of ellipses.  Changing the IDs on the last two is primarily to make it easier to find the mapping b/w widgets and strings.

likely additions: 

 <!ENTITY hdrReplyButton.label "reply">
 <!ENTITY hdrForwardButton.label "forward">
 <!ENTITY hdrJunkButton.label "mark as junk">
 <!ENTITY hdrTrashButton.tooltiptext "delete">

Note: while doing so,remove the following after making sure they're not used by anyone else:

  <!ENTITY replyButton.label "reply…">
  <!ENTITY forwardButton.label "forward…">
  <!ENTITY junkButton.label "mark as junk">
  <!ENTITY trashButton.tooltiptext "delete">
Flags: blocking-thunderbird3+
Assignee: nobody → david.ascher
The revised Entities clarify what they apply to. I assume these are related to what Theme Devs would use to skin the buttons, so less confusion with Toolbar entities.
In addition to removing the ellipses, I'd also suggest title casing the button captions, so the button style matches the rest of the TB UI (toolbars, options dialog, account dialog, etc.).  The buttons would then read: Reply, Forward, Mark as Junk, Delete, etc.
likely won't get to this for b2.
Priority: -- → P3
Target Milestone: Thunderbird 3.0b2 → Thunderbird 3.0b3
With Windows builds the ellipses have been gone for a few days.
neat!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Only if you also think it's neat to take people on long hikes and then run off into the woods leaving them there: http://mxr.mozilla.org/l10n-central/search?string=replyButton.label&find=msgHdrViewOverlay.dtd

Bug 451995 removed the ellipses while adding the archive button, but didn't rev the entity names, so now we have a few locales that thought en-US was being silly with lowercase and/or the ellipsis in the first place and never did use them, a few locales that look at everything in a patch which changes any entities, so they picked up the change despite not having an entity name change, and 35 locales who thought a hike in the woods sounded great, right up until the time when we ran off and abandoned them.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
i suspect dmose wants this as part of owning the message reader
Assignee: david.ascher → dmose
Stealing to do this and bug 476555 in one fell swoop.
Assignee: dmose → philringnalda
Status: REOPENED → ASSIGNED
Summary: remove ellipses from reply and forward in message reader → tweak entity names so that all locales pick up the removal of ellipsis from reply & forward
Attached patch FixSplinter Review
Much as I tried, I couldn't come up with any excuse to rename trashButton.tooltiptext (which at least is a string only used in the one place), but this gets the key change that bug 451995 should have made while removing the ellipses, and in the process makes it easier to tell these from the labels for the toolbar buttons, and does the "mark as junk" -> "junk" for bug 476555.
Attachment #360440 - Flags: review?(mkmelin+mozilla)
I don't know if this is intentional or if there is a good reason for it, but the button captions are still lower case in this patch.  This is different from the rest of the button captions in TB (at least my build of it - see the main toolbar buttons, options dialog, about box, account wizard, etc.).
Comment on attachment 360440 [details] [diff] [review]
Fix

r=mkmelin, as long as we're reasonably sure we want the button labels lower case, and don't have to change it once more later. 

I don't have a strong opinion about those, but there are other places like the "other actions" dropdown and the header names where i do think we should make it to Upper case.
Attachment #360440 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: Thunderbird 3.0b3 → Thunderbird 3.0b2
Whiteboard: [has l10n impact]
Keywords: push-needed
Keywords: push-needed
Whiteboard: [has l10n impact] → [has l10n impact][philor to checkin]
http://hg.mozilla.org/comm-central/rev/adae126ae987
Status: ASSIGNED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Whiteboard: [has l10n impact][philor to checkin] → [has l10n impact]
You need to log in before you can comment on or make changes to this bug.